FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Speech api changes by puneith · Pull Request #267 · GoogleCloudPlatform/java-docs-samples · GitHub

/ java-docs-samples Public

Speech api changes - #267

Merged
puneith merged 32 commits into
masterfrom
speech_api_changes
Jul 12, 2016
ConversationCommits (32)ChecksFiles changed
Merged

Speech api changes#267
puneith merged 32 commits into
masterfrom
speech_api_changes

Conversation

puneith commented Jul 6, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor

@tswast Please review. This PR contains the changes due to Speech API changes, namely Sync, Async and Streaming.

puneithk added 14 commits July 6, 2016 11:40
renamed from recognize to streaming recognize
89f445c 
Author: puneith <puneith@google.com>
added v1beta1 proto
1408b15 
Author: puneith <puneith@google.com>
added long running operation
6ac06c5 
Author: puneith <puneith@google.com>
made changes to the script
34f300c 
Author: puneith <puneith@google.com>
renamed to sync recognize client
259ed6a 
Author: puneith <puneith@google.com>
added sync changes and test
4415993 
Author: puneith <puneith@google.com>
added sync changes and test
3892470 
Author: puneith <puneith@google.com>
made changes to script and tests
e1516d2 
Author: puneith <puneith@google.com>
deleted
ed629b6 
Author: puneith <puneith@google.com>
made sync work
20e6b88 
Author: puneith <puneith@google.com>
added async
6f513ca 
Author: puneith <puneith@google.com>
added async samples
f221210 
Author: puneith <puneith@google.com>
added async response unpack
f9ac582 
Author:    puneith <puneith@google.com>
fixed formatting
2b949f6

tswast commented Jul 6, 2016

Copy link
Copy Markdown
Contributor

@lesv PTAL as well.

codecov-io commented Jul 6, 2016 •
edited
Loading

Copy link
Copy Markdown

Current coverage is 44.59%

Merging #267 into master will decrease coverage by 2.16%

@@             master       #267   diff @@
==========================================
  Files            77         78     +1   
  Lines          2164       2267   +103   
  Methods           0          0          
  Messages          0          0          
  Branches        148        154     +6   
==========================================
- Hits           1012       1011     -1   
- Misses         1121       1225   +104   
  Partials         31         31

Powered by Codecov. Last updated by 6377365...5a6d2ca

tswast reviewed Jul 6, 2016
View reviewed changes
Comment thread speech/grpc/src/main/java/com/google/cloud/speech/grpc/demos/AsyncRecognizeClient.java Outdated
//
// Then set environment variable GOOGLE_APPLICATION_CREDENTIALS to the full path of that file.

package com.google.cloud.speech.grpc.demos;

tswast Jul 6, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

For new samples we have been using com.example package instead of com.google. This is to make it more clear to the user that they can change the package to match their own project.

puneith Jul 7, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This structure already existed. I didn't mess up with the package name. Change it still?

lesv Jul 7, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry about pinging on the package name, it looks like whom ever reviewed the first version wasn't on the Java team. :(

puneith Jul 11, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@lesv @tswast Its common to put company name in the package even samples. This is google code so why not? https://github.com/linkedin/api-get-started/tree/master/java/src/com/linkedin/sample

lesv Jul 11, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

See RFC 2606

lesv commented Jul 7, 2016

Copy link
Copy Markdown
Contributor

For the README.md - is the whole SERVICE ACCOUNT stuff still required?

lesv reviewed Jul 7, 2016
View reviewed changes
Comment thread speech/grpc/README.md
or [homebrew](http://brew.sh/)) to convert audio files to raw format.

### Run the non-streaming client
### Run the sync client

lesv Jul 7, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

How does it work on Windows?

puneith Jul 11, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Don't know, is that a blocker?

puneith Jul 11, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@lesv we don't have the instructions anywhere otherwise and assuming users would have read everything before using this sample is not correct either. So we need them IMHO.

lesv Jul 12, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please add an issue for this.

puneith Jul 12, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Issue for windows or that we don't have instructions anywhere else?

lesv reviewed Jul 12, 2016
View reviewed changes
Comment thread speech/grpc/README.md
@@ -73,20 +73,35 @@ note that the audio file must be in RAW format. You can use `sox`
(available, e.g. via [http://sox.sourceforge.net/](http://sox.sourceforge.net/)

lesv Jul 12, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

README should mention that this is BETA software w/ a link to what that means: https://cloud.google.com/terms/launch-stages

It should also mention that this samples is for Advanced Users.

lesv removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. NEEDS WORK labels Jul 12, 2016

lesv commented Jul 12, 2016

Copy link
Copy Markdown
Contributor

LGTM

lesv commented Jul 12, 2016

Copy link
Copy Markdown
Contributor

There should be some additional items for catchup after merge.

puneith merged commit fdd5eb2 into master Jul 12, 2016
Shabirmean pushed a commit that referenced this pull request Nov 15, 2022
chore(deps): update dependency com.google.cloud:libraries-bom to v15.…
b265d29 
…1.0 (#267)
Shabirmean mentioned this pull request Nov 15, 2022
Merged
9 tasks
Shabirmean pushed a commit that referenced this pull request Nov 15, 2022
chore(deps): update dependency com.google.cloud:libraries-bom to v15.…
532fc84 
…1.0 (#267)
Shabirmean pushed a commit that referenced this pull request Nov 17, 2022
samples: Translate flaky tests (#297)
7ea2179 
Fixes #292 #268 #267   ☕️

This is the draft
I do not know it is considered as good test design using base class 

I basically got the idea from the stack overflow answer: 

https://stackoverflow.com/questions/8295100/how-to-re-run-failed-junit-tests-immediately
Shabirmean pushed a commit that referenced this pull request Nov 18, 2022
samples: Translate flaky tests (#297)
35c3cea 
Fixes #292 #268 #267   ☕️

This is the draft
I do not know it is considered as good test design using base class 

I basically got the idea from the stack overflow answer: 

https://stackoverflow.com/questions/8295100/how-to-re-run-failed-junit-tests-immediately
Shabirmean pushed a commit that referenced this pull request Nov 18, 2022
samples: Translate flaky tests (#297)
7add728 
Fixes #292 #268 #267   ☕️

This is the draft
I do not know it is considered as good test design using base class 

I basically got the idea from the stack overflow answer: 

https://stackoverflow.com/questions/8295100/how-to-re-run-failed-junit-tests-immediately
anguillanneuf pushed a commit that referenced this pull request Dec 5, 2022
samples: Translate flaky tests (#297)
73fe13b 
Fixes #292 #268 #267   ☕️

This is the draft
I do not know it is considered as good test design using base class 

I basically got the idea from the stack overflow answer: 

https://stackoverflow.com/questions/8295100/how-to-re-run-failed-junit-tests-immediately
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL