fix: talent solution v4 samples tests - #2977
Merged
lesv merged 7 commits intoMay 28, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
lesv
approved these changes
May 27, 2020
lesv
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Approve, but I really think using protobuf.Timestamp is a very bad idea and should be discouraged.
Sorry, something went wrong.
Comment thread
jobs/v4/src/main/java/com/example/jobs/JobSearchCreateJob.java
Outdated
Comment thread
jobs/v4/src/main/java/com/example/jobs/JobSearchCreateJob.java
Outdated
Copy link
Copy Markdown
Contributor
Author
|
@lesv Looks like I do not have a write permission to merge this |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewerAssignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2970
Looks like job posting by default was expired and deleted in 30 days.
That's why this happens once in a month.
I found out that I can customize the expiration date in job posting, and created one job for testing that expires in 40 years from now.