refactor: use new verify token functionality from google-auth-library - #2986
Merged
chingor13 merged 6 commits intoJun 25, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
bshaffer
reviewed
May 29, 2020
bshaffer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I know it's a draft but this looks fantastic, nice work.
Sorry, something went wrong.
bshaffer
reviewed
May 29, 2020
Comment thread
iap/src/main/java/com/example/iap/VerifyIapRequestHeader.java
Outdated
bshaffer
reviewed
May 29, 2020
averikitsch
approved these changes
Jun 10, 2020
Comment thread
iap/src/main/java/com/example/iap/VerifyIapRequestHeader.java
Outdated
chingor13
marked this pull request as ready for review
June 24, 2020 20:53
averikitsch
approved these changes
Jun 24, 2020
9 tasks
bshaffer
approved these changes
Jun 25, 2020
bshaffer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
One minor suggestion and totally up to you. Otherwise, this is double-approved. The net removal of 60 lines of code makes me quite happy.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
google-auth-library 0.21.0 is available, so this is ready to go.