samples(test): refactor automl test - #3588
Merged
gcf-merge-on-green[bot] merged 5 commits intoAug 22, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
lesv
approved these changes
Aug 21, 2020
lesv
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Please answer the Q, then ask me to merge - ok if you can as well.
Sorry, something went wrong.
Comment thread
automl/cloud-client/src/test/java/com/example/automl/GetOperationStatusTest.java
Outdated
Copy link
Copy Markdown
Contributor
Author
|
@lesv What is the right way to put timeout on After tag? @After @Test(timeout = 1000) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
From what I can see, for JUnit4 and StackOverflow, you typically put them at the top of the test method. JUnit5 has a different way of expressing it - it works only on certain kinds of things. Note - the default TO is in ms. |
Sorry, something went wrong.
lesv
approved these changes
Aug 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3550
Looks like in setup, ListOperations that had a very long list of operations to list which making a test to wait for 10-15min, Then, sometimes it fails with a internal error.