remove "secure: always" from Flexible samples. - #545
Merged
lesv merged 2 commits intoMar 5, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
the "secure" directive it does nothing in Flexible and it's presence can imply support for this feature.
the "secure" directive it does nothing in Flexible.
lesv
approved these changes
Mar 5, 2017
lesv
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM - is there something else that should be there, or is Flex now always secure?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Expected failure. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There is no replacement for this feature in the Flexible platform see internal issue b/28618963 Thanks |
Sorry, something went wrong.
Shabirmean
pushed a commit
that referenced
this pull request
Nov 10, 2022
…o v2.5.0 (#545) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-retail](https://togithub.com/googleapis/java-retail) ([source](https://togithub.com/googleapis/java-)) | `2.4.0` -> `2.5.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-retail). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTUuNSIsInVwZGF0ZWRJblZlciI6IjMyLjE5NS41In0=-->
9 tasks
9 tasks
olivi-eh
pushed a commit
that referenced
this pull request
Nov 11, 2022
…tion to v0.122.23-beta (#545)
Shabirmean
pushed a commit
that referenced
this pull request
Nov 11, 2022
9 tasks
Sita04
pushed a commit
that referenced
this pull request
Nov 11, 2022
9 tasks
Sita04
pushed a commit
that referenced
this pull request
Nov 15, 2022
Shabirmean
pushed a commit
that referenced
this pull request
Nov 15, 2022
…o v2.5.0 (#545) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-retail](https://togithub.com/googleapis/java-retail) ([source](https://togithub.com/googleapis/java-)) | `2.4.0` -> `2.5.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-retail). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTUuNSIsInVwZGF0ZWRJblZlciI6IjMyLjE5NS41In0=-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "secure" directive is ignored in Flexible.