consolidating flex samples into single project - #633
Closed
jabubake wants to merge 3 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
lesv
approved these changes
Apr 28, 2017
lesv
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I did a quick scan which didn't seem like 147 files, but maybe it was 2.2k lines so all is well. Anyway, I liked the change in path, and everything else. Didn't find a consolidated README, but LGTM. You can fix the README after the fact.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Oh, fix Circle first, however. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@lesv will do : will fix the README and also looking into the testing
concerns you brought up.
…On Fri, Apr 28, 2017 at 11:19 AM, Les Vogel ***@***.***> wrote:
Oh, fix Circle first, however.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#633 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AWfpWzT5arKd9BCU-5B056kSu9TF1py1ks5r0i2WgaJpZM4NJOjf>
.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Hello, |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
End of this week is what I'm targeting. Hold up : making sure we can set
the env vars correctly in app.yaml for testing.
Is this a blocker for anything ? I had n't prioritized this accordingly, if
so.
…On Wed, May 10, 2017 at 10:14 AM, Ludovic Champenois < ***@***.***> wrote:
Hello,
do we have an ETA for this to land?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#633 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AWfpW9sV0tQTgmD2jxoYur-erP1L6Pquks5r4fB8gaJpZM4NJOjf>
.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
What I'm doing is different from this one.
On Wed, May 10, 2017 at 10:41 AM, Jisha Abubaker <notifications@github.com>
wrote:
… End of this week is what I'm targeting. Hold up : making sure we can set
the env vars correctly in app.yaml for testing.
Is this a blocker for anything ? I had n't prioritized this accordingly, if
so.
On Wed, May 10, 2017 at 10:14 AM, Ludovic Champenois <
***@***.***> wrote:
> Hello,
> do we have an ETA for this to land?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/GoogleCloudPlatform/java-docs-
samples/pull/633#issuecomment-300550956>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-
auth/AWfpW9sV0tQTgmD2jxoYur-erP1L6Pquks5r4fB8gaJpZM4NJOjf>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#633 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABFVjtu4JOhIVcHqBlapGeykhEfba5lEks5r4fa7gaJpZM4NJOjf>
.
--
* • **Les Vogel*
* • *Cloud Developer Relations
* • *lesv@google.com
* • *+1-4 <%2B1-650-338-7103>08-676-7023
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
will close this PR and re-do at a later time. |
Sorry, something went wrong.
9 tasks
ivanmkc
pushed a commit
that referenced
this pull request
Nov 3, 2022
…633) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | `23.1.0` -> `24.0.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-datalabeling).
averikitsch
pushed a commit
that referenced
this pull request
Nov 9, 2022
…633) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | `23.1.0` -> `24.0.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-datalabeling).
Shabirmean
pushed a commit
that referenced
this pull request
Nov 15, 2022
…-ai to v2.1.2 (#633) * chore(deps): update dependency com.google.cloud:google-cloud-document-ai to v2.1.2 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
9 tasks
Shabirmean
pushed a commit
that referenced
this pull request
Nov 15, 2022
…-ai to v2.1.2 (#633) * chore(deps): update dependency com.google.cloud:google-cloud-document-ai to v2.1.2 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After looking at how how we use these samples in our docs, I think our vision of having the single app must not burden users who just want to see the single servlet Flex sample demonstrating a particular functionality. It should also not burden the contributors.
Let me know if this current approach makes sense. the samples-builder under flexible/java-runtime/samples creates the bundled app on the fly from all or a subset of the samples.