FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: add maven-war-plugin to fix java17 periodic failures by shubha-rajan · Pull Request #7117 · GoogleCloudPlatform/java-docs-samples · GitHub

/ java-docs-samples Public

chore: add maven-war-plugin to fix java17 periodic failures - #7117

Merged
shubha-rajan merged 4 commits into
mainfrom
maven-war-plugin
May 6, 2022
ConversationCommits (4)ChecksFiles changed
Merged

chore: add maven-war-plugin to fix java17 periodic failures#7117
shubha-rajan merged 4 commits into
mainfrom
maven-war-plugin

Conversation

shubha-rajan commented May 6, 2022

Copy link
Copy Markdown
Contributor

A lot of tests are failing in Java 17 with an error that looks like:

[WARNING] Error injecting: org.apache.maven.plugin.war.WarMojo
com.google.inject.ProvisionException: Unable to provision, see the following errors:

1) Error injecting constructor, java.lang.ExceptionInInitializerError: Cannot access defaults field of Properties
  at org.apache.maven.plugin.war.WarMojo.<init>(Unknown Source)
  while locating org.apache.maven.plugin.war.WarMojo
...

Adding maven-war-plugin fixes these errors.

shubha-rajan requested review from a team and yoshi-approver as code owners May 6, 2022 20:16
product-auto-label Bot added the samples Issues that are directly related to samples. label May 6, 2022
shubha-rajan mentioned this pull request May 6, 2022
Merged
1 task

ludoch commented May 6, 2022

Copy link
Copy Markdown
Contributor

Can't it be done in a more centralized location? Parent pom?

shubha-rajan commented May 6, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Can't it be done in a more centralized location? Parent pom?

I considered that, but not all the samples need the plugin. Also many of the samples already have the plugin, these were just the samples that were missing it. Should we still add it to the parent pom?

lesv approved these changes May 6, 2022
View reviewed changes

lesv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, but I'm w/ Ludo, this probably could have been done in java-repo-tools, but this is likely to fix things quicker.

shubha-rajan merged commit d944990 into main May 6, 2022
shubha-rajan deleted the maven-war-plugin branch May 6, 2022 22:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner
1 more reviewer
lesv lesv approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

anguillanneuf

Labels

samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL