FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Postgres & CloudSQL update for flex by lesv · Pull Request #738 · GoogleCloudPlatform/java-docs-samples · GitHub

/ java-docs-samples Public

Postgres & CloudSQL update for flex - #738

Merged
lesv merged 1 commit into
masterfrom
postgre-cloudsql
Jun 29, 2017
ConversationCommits (1)ChecksFiles changed
Merged

Postgres & CloudSQL update for flex#738
lesv merged 1 commit into
masterfrom
postgre-cloudsql

Conversation

lesv commented Jun 29, 2017

Copy link
Copy Markdown
Contributor
  1. update cloudSql to latest plugin and make the sample a bit cleaner.
  2. add postgresql sample.

Postgres & CloudSQL update for flex
dc8e24f 
1. update cloudSql to latest plugin and make the sample a bit cleaner.
2. add postgresql sample.
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 29, 2017
lesv requested a review from jabubake June 29, 2017 18:20

lesv commented Jun 29, 2017

Copy link
Copy Markdown
Contributor Author

I'm going to merge, but I'd rather the init method threw all the things I catch.

lesv commented Jun 29, 2017

Copy link
Copy Markdown
Contributor Author

Well, I can't change init() to add the other types, so I'm going to keep this.

lesv merged commit 03d504c into master Jun 29, 2017
lesv deleted the postgre-cloudsql branch June 29, 2017 18:26
jabubake reviewed Jun 29, 2017
View reviewed changes

jabubake left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, minor comments.

Comment thread flexible/cloudsql/src/main/java/com/example/cloudsql/CloudSqlServlet.java
log("connecting to: " + url);
try {
Class.forName("com.mysql.jdbc.Driver");
conn = DriverManager.getConnection(url);

jabubake Jun 29, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

(optional/future) instead of DriverManager.getConnection,
connection pooling with commons-bcp : https://mvnrepository.com/artifact/org.apache.commons/commons-dbcp2

Comment thread flexible/postgres/src/main/appengine/app.yaml
@@ -0,0 +1,24 @@
# Copyright 2016 Google Inc.

jabubake Jun 29, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

2017

Comment thread flexible/postgres/src/main/java/com/example/postgres/PostgresSqlServlet.java
@@ -0,0 +1,127 @@
/**
* Copyright 2016 Google Inc.

jabubake Jun 29, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

2017

Shabirmean pushed a commit that referenced this pull request Nov 14, 2022
samples: added region tags (#738)
3b317cb 
* Tag fix

* rerun conventional commit
Shabirmean mentioned this pull request Nov 15, 2022
Merged
9 tasks
Shabirmean pushed a commit that referenced this pull request Nov 15, 2022
samples: added region tags (#738)
8bb5f0b 
* Tag fix

* rerun conventional commit
Shabirmean pushed a commit that referenced this pull request Nov 17, 2022
chore: migrate to owlbot (#738)
edd5830
Shabirmean mentioned this pull request Nov 17, 2022
Merged
9 tasks
Shabirmean pushed a commit that referenced this pull request Nov 18, 2022
chore: migrate to owlbot (#738)
935a9f0
anguillanneuf pushed a commit that referenced this pull request Dec 5, 2022
chore: migrate to owlbot (#738)
e7aecb1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
jabubake jabubake left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL