FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: update speech sample to check list count by averikitsch · Pull Request #7857 · GoogleCloudPlatform/java-docs-samples · GitHub

/ java-docs-samples Public

fix: update speech sample to check list count - #7857

Merged
kweinmeister merged 2 commits into
mainfrom
akitsch-speech
Apr 10, 2023
ConversationCommits (2)ChecksFiles changed
Merged

fix: update speech sample to check list count#7857
kweinmeister merged 2 commits into
mainfrom
akitsch-speech

Conversation

averikitsch commented Apr 7, 2023

Copy link
Copy Markdown
Contributor

Fixes #issue

It's a good idea to open an issue first for discussion.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

averikitsch requested review from a team and yoshi-approver as code owners April 7, 2023 21:06
product-auto-label Bot added samples Issues that are directly related to samples. api: speech Issues related to the Speech-to-Text API. labels Apr 7, 2023
This was linked to issues Apr 7, 2023
com.example.speech.QuickstartSampleV2IT: testQuickstart failed #7839
Closed
com.example.speech.TranscribeFileV2IT: testQuickstart failed #7840
Closed
averikitsch mentioned this pull request Apr 7, 2023
Merged
1 task
kweinmeister merged commit 0dabb39 into main Apr 10, 2023
kweinmeister deleted the akitsch-speech branch April 10, 2023 15:21

telpirion commented Apr 10, 2023

Copy link
Copy Markdown
Contributor

That's pretty concerning that sometimes the Speech V2 sample fails to return anything sometimes--especially when given the same input. We should investigate this further.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner
1 more reviewer
Shabirmean Shabirmean approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

Shabirmean

Labels

api: speech Issues related to the Speech-to-Text API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

com.example.speech.TranscribeFileV2IT: testQuickstart failed com.example.speech.QuickstartSampleV2IT: testQuickstart failed

4 participants

Back | FazBrowse Home | New Git URL