FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

updating Firebase on App Engine sample to use latest libs by jabubake · Pull Request #862 · GoogleCloudPlatform/java-docs-samples · GitHub

/ java-docs-samples Public

updating Firebase on App Engine sample to use latest libs - #862

Merged
jabubake merged 3 commits into
masterfrom
patch-appengine-firestore
Sep 25, 2017
ConversationCommits (3)ChecksFiles changed
Merged

updating Firebase on App Engine sample to use latest libs#862
jabubake merged 3 commits into
masterfrom
patch-appengine-firestore

Conversation

jabubake commented Sep 25, 2017

Copy link
Copy Markdown
Contributor

Fixing issue in running app locally as reported by customer:
https://cloud.google.com/appengine/docs/deprecations/channel

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 25, 2017
jabubake requested a review from lesv September 25, 2017 17:07
lesv approved these changes Sep 25, 2017
View reviewed changes

lesv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM - comments are nits

Comment thread appengine/firebase-tictactoe/README.md Outdated

## Setup

* If you haven't already, Download and initialize the [Cloud SDK](https://cloud.google.com/sdk/)

lesv Sep 25, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Shouldn't this be a Prerequisite?

jabubake Sep 25, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

done

Comment thread appengine/firebase-tictactoe/README.md
```
gcloud init
```
* If you haven't already, Create an App Engine app within the current Google Cloud Project

lesv Sep 25, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Redundant phrase

jabubake Sep 25, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

cleaned up

Comment thread appengine/firebase-tictactoe/README.md
Download [service account credentials][creds] and set the `GOOGLE_APPLICATION_CREDENTIALS`
environment variable to its path:
```
export GOOGLE_APPLICATION_CREDENTIALS=/path/to/your/credentials.json

lesv Sep 25, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should we have them set GOOGLE_CLOUD_PROJECT? Look at gcloud config to verify their project?

jabubake Sep 25, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

given we still ask users to use gcloud init : added a note there that this sets the project.

Comment thread ...ngine/firebase-tictactoe/src/test/java/com/example/appengine/firetactoe/MoveServletTest.java

game = ofy.load().type(Game.class).id(gameKey).safe();
assertThat(game.board).isEqualTo(" X ");
assertEquals(game.board, " X ");

lesv Sep 25, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Truth might make this cleaner.

jabubake Sep 25, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Minimizing test dependencies, so leaving this as-is

jabubake merged commit 1ec2907 into master Sep 25, 2017
jabubake deleted the patch-appengine-firestore branch September 25, 2017 20:30
minherz pushed a commit that referenced this pull request Nov 9, 2022
chore(deps): update dependency com.google.cloud:libraries-bom to v25.…
daf0ca0 
…3.0 (#862)

* chore(deps): update dependency com.google.cloud:libraries-bom to v25.3.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
minherz pushed a commit that referenced this pull request Nov 10, 2022
chore(deps): update dependency com.google.cloud:libraries-bom to v25.…
8700978 
…3.0 (#862)

* chore(deps): update dependency com.google.cloud:libraries-bom to v25.3.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
minherz pushed a commit that referenced this pull request Nov 10, 2022
chore(deps): update dependency com.google.cloud:libraries-bom to v25.…
676bdb8 
…3.0 (#862)

* chore(deps): update dependency com.google.cloud:libraries-bom to v25.3.0

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sita04 pushed a commit that referenced this pull request Feb 7, 2023
chore(main): release 3.3.0 (#862)
4a2e889 
🤖 I have created a release *beep* *boop*
---


## [3.3.0](googleapis/java-dlp@v3.2.1...v3.3.0) (2022-04-15)


### Features

* add DataProfilePubSubMessage supporting pub/sub integration ([#855](googleapis/java-dlp#855)) ([86eeaaa](googleapis/java-dlp@86eeaaa))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.10.0 ([#863](googleapis/java-dlp#863)) ([a0a3164](googleapis/java-dlp@a0a3164))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
lesv lesv approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL