Datastore Concepts snippets and Getting Started app - #90
Conversation
Sorry, something went wrong.
| .set("priority", 5) | ||
| .set("description", "Integrate Cloud Datastore") | ||
| .build(); | ||
| // [START batch_upsert] |
There was a problem hiding this comment.
Sorry this changed recently, but can you include creation of entities + keys in the snippet too?
Sorry, something went wrong.
There was a problem hiding this comment.
Ah sorry --
These should be automatically allocated ids. We should show how to extract the keys from the batch afterwards.
Sorry, something went wrong.
There was a problem hiding this comment.
Since v1beta2 doesn't support upsert with auto id allocation, can we make this a batch insert instead of upsert? Sorry I didn't catch this, these snippets were designed for v1beta3.
Sorry, something went wrong.
There was a problem hiding this comment.
Got it, updated in the latest commit.
Sorry, something went wrong.
|
Looks great, thanks Ajay! |
Sorry, something went wrong.
|
Incorporated Patrick's feedback. Also /cc @lesv |
Sorry, something went wrong.
| markDone(id); | ||
| System.out.println("task marked done"); | ||
| } catch (DatastoreException e) { | ||
| System.out.printf("did not find a Task entity with ID %d\n", id); |
There was a problem hiding this comment.
Nit, you can use %n instead of \n
Sorry, something went wrong.
|
Pushed a commit to incorporate @aozarov feedback. Ready for another round of review. |
Sorry, something went wrong.
| @@ -0,0 +1,14 @@ | |||
| ## Datastore Samples | |||
|
|
|||
| This directory contains sample code used in Google Cloud Datastore documentation. Included here is a sample command line application, `TaskList`, that interacts with Datastore to manage a to-do list. | |||
There was a problem hiding this comment.
App Engine Managed VMs or Standard?
Sorry, something went wrong.
There was a problem hiding this comment.
Ah MVM / any Java.
Sorry, something went wrong.
|
LGTM - your choice to update readme / pom for nits. |
Sorry, something went wrong.
|
LGTM. Nice job! |
Sorry, something went wrong.
Datastore Concepts snippets and Getting Started app
|
Totally agree - very nice job! |
Sorry, something went wrong.
….0 (#90) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | minor | `4.2.0` -> `4.3.0` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-errorreporting).
….0 (#90) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | minor | `4.2.0` -> `4.3.0` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-errorreporting).
….0 (#90) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | minor | `4.2.0` -> `4.3.0` | --- ### Renovate configuration :date: **Schedule**: At any time (no schedule defined). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#googleapis/java-errorreporting).
/cc @pcostell @aozarov