FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: delete OpenTelemetry spring-boot-instrumentation sample since it has been moved by aabmass · Pull Request #9236 · GoogleCloudPlatform/java-docs-samples · GitHub

/ java-docs-samples Public

chore: delete OpenTelemetry spring-boot-instrumentation sample since it has been moved - #9236

Merged
minherz merged 1 commit into
GoogleCloudPlatform:mainfrom
aabmass:delete-otel-instrumentation
Feb 5, 2024
ConversationCommits (1)ChecksFiles changed
Merged

chore: delete OpenTelemetry spring-boot-instrumentation sample since it has been moved#9236
minherz merged 1 commit into
GoogleCloudPlatform:mainfrom
aabmass:delete-otel-instrumentation

Conversation

aabmass commented Feb 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This sample has been moved to https://github.com/GoogleCloudPlatform/opentelemetry-operations-java/tree/main/examples/instrumentation-quickstart. The snippets are not used in any live documentation

Fixes #8979

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

product-auto-label Bot added the samples Issues that are directly related to samples. label Feb 5, 2024
aabmass marked this pull request as ready for review February 5, 2024 20:53
aabmass requested review from a team and yoshi-approver as code owners February 5, 2024 20:53

snippet-bot Bot commented Feb 5, 2024

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

minherz approved these changes Feb 5, 2024
View reviewed changes

minherz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

minherz assigned minherz and unassigned kweinmeister Feb 5, 2024
minherz merged commit 7abc3ef into GoogleCloudPlatform:main Feb 5, 2024
aabmass deleted the delete-otel-instrumentation branch February 5, 2024 21:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

minherz minherz approved these changes
yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees

minherz

Labels

samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

opentelemetry/spring-boot-instrumentation test(s) are failing

3 participants

Back | FazBrowse Home | New Git URL