FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add kms/attestations/ directory with sample script to verify attestations by bkuang · Pull Request #3262 · GoogleCloudPlatform/python-docs-samples · GitHub

/ python-docs-samples Public

Add kms/attestations/ directory with sample script to verify attestations - #3262

Merged
tmatsuo merged 2 commits into
GoogleCloudPlatform:masterfrom
bkuang:master
May 1, 2020
ConversationCommits (2)ChecksFiles changed
Merged

Add kms/attestations/ directory with sample script to verify attestations#3262
tmatsuo merged 2 commits into
GoogleCloudPlatform:masterfrom
bkuang:master

Conversation

bkuang commented Apr 2, 2020 •
edited by tmatsuo
Loading

Copy link
Copy Markdown
Contributor

This adds a kms/attestations/ directory to hold code samples that deal with attestations and certificates obtained from Cloud HSM. This also adds a verify_attestation.py script to verify attestations using certificate bundles containing one or more certificates.

fixes #3246

bkuang requested review from a team and daniel-sanche as code owners April 2, 2020 18:03
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 2, 2020

mdlinville commented Apr 2, 2020

Copy link
Copy Markdown

/assign

mdlinville reviewed Apr 2, 2020
View reviewed changes

mdlinville left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please also get technical review. :)

Comment thread kms/attestations/README.rst.in Outdated
Comment thread kms/attestations/README.rst.in Outdated
Comment thread kms/attestations/verify_attestation.py Outdated
Comment thread kms/attestations/verify_attestation.py Outdated
Comment thread kms/attestations/verify_attestation.py Outdated
Comment thread kms/attestations/verify_attestation.py Outdated
Comment thread kms/attestations/verify_attestation.py Outdated
Comment thread kms/attestations/verify_attestation.py Outdated
Comment thread kms/attestations/verify_attestation.py Outdated
Comment thread kms/attestations/verify_attestation.py Outdated
tmatsuo reviewed Apr 6, 2020
View reviewed changes
Comment thread kms/attestations/verify_attestation_test.py Outdated
bkuang requested review from tmatsuo and removed request for a team April 8, 2020 22:00
tmatsuo reviewed Apr 9, 2020
View reviewed changes
Comment thread kms/attestations/verify_attestation.py Outdated
Comment thread kms/attestations/verify_attestation.py Outdated
bkuang requested a review from tmatsuo April 9, 2020 13:47
tmatsuo approved these changes Apr 20, 2020
View reviewed changes
Comment thread kms/attestations/verify_attestation_test.py Outdated
tmatsuo added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 24, 2020
kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 24, 2020

tmatsuo commented Apr 24, 2020

Copy link
Copy Markdown
Contributor

@bkuang

In case you don't have access to the logs:
Lint fails with

./verify_attestation_test.py:134:1: W391 blank line at end of file

^
./verify_attestation.py:96:1: W391 blank line at end of file

^

Pytho builds failed with:

Program pytest not found.

I think you have to rebase to github master.

tmatsuo added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 25, 2020
kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 25, 2020
tmatsuo added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 27, 2020
kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 27, 2020
tmatsuo added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 27, 2020
kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 27, 2020
daniel-sanche reviewed Apr 27, 2020
View reviewed changes
Comment thread kms/attestations/verify_attestation.py Outdated
daniel-sanche reviewed Apr 27, 2020
View reviewed changes
Comment thread kms/attestations/verify_attestation.py Outdated
daniel-sanche reviewed Apr 27, 2020
View reviewed changes
Comment thread kms/attestations/verify_attestation.py Outdated
tmatsuo suggested changes Apr 29, 2020
View reviewed changes

tmatsuo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry I didn't point it out in the first pass, but I think it is harmful to completely swallow exceptions.

Comment thread kms/attestations/verify_attestation.py Outdated
daniel-sanche reviewed Apr 29, 2020
View reviewed changes
Comment thread kms/attestations/verify_attestation.py Outdated
daniel-sanche approved these changes Apr 30, 2020
View reviewed changes

daniel-sanche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

tmatsuo added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 1, 2020
kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 1, 2020
tmatsuo merged commit 4dab181 into GoogleCloudPlatform:master May 1, 2020
busunkim96 pushed a commit to busunkim96/python-kms that referenced this pull request Jun 16, 2020
Add kms/attestations/ directory with sample script to verify attestat…
0b3e426 
…ions [(#3262)](GoogleCloudPlatform/python-docs-samples#3262)

Co-authored-by: Benson Kuang <benkuang@google.com>
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
busunkim96 pushed a commit to busunkim96/python-kms that referenced this pull request Jun 16, 2020
Add kms/attestations/ directory with sample script to verify attestat…
22e6b23 
…ions [(#3262)](GoogleCloudPlatform/python-docs-samples#3262)

Co-authored-by: Benson Kuang <benkuang@google.com>
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
busunkim96 pushed a commit to googleapis/python-kms that referenced this pull request Jun 16, 2020
Add kms/attestations/ directory with sample script to verify attestat…
ea487f3 
…ions [(#3262)](GoogleCloudPlatform/python-docs-samples#3262)

Co-authored-by: Benson Kuang <benkuang@google.com>
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
rsamborski mentioned this pull request Nov 8, 2022
Merged
8 tasks
rsamborski pushed a commit that referenced this pull request Nov 8, 2022
Add kms/attestations/ directory with sample script to verify attestat…
f2c8b55 
…ions [(#3262)](#3262)

Co-authored-by: Benson Kuang <benkuang@google.com>
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
rsamborski pushed a commit that referenced this pull request Nov 11, 2022
Add kms/attestations/ directory with sample script to verify attestat…
a35ced9 
…ions [(#3262)](#3262)

Co-authored-by: Benson Kuang <benkuang@google.com>
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
rsamborski pushed a commit that referenced this pull request Nov 14, 2022
Add kms/attestations/ directory with sample script to verify attestat…
aecda49 
…ions [(#3262)](#3262)

Co-authored-by: Benson Kuang <benkuang@google.com>
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
dandhlee pushed a commit that referenced this pull request Nov 14, 2022
Add kms/attestations/ directory with sample script to verify attestat…
6a442b4 
…ions [(#3262)](#3262)

Co-authored-by: Benson Kuang <benkuang@google.com>
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 21, 2023
Add kms/attestations/ directory with sample script to verify attestat…
ef40524 
…ions [(#3262)](GoogleCloudPlatform/python-docs-samples#3262)

Co-authored-by: Benson Kuang <benkuang@google.com>
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

daniel-sanche daniel-sanche approved these changes
+2 more reviewers
mdlinville mdlinville left review comments
tmatsuo tmatsuo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

gguuss

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create sample scripts for verifying HSM certificates and attestations

7 participants

Back | FazBrowse Home | New Git URL