FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

migrate code from googleapis/python-kms by rsamborski · Pull Request #8470 · GoogleCloudPlatform/python-docs-samples · GitHub

/ python-docs-samples Public

migrate code from googleapis/python-kms - #8470

Merged
dandhlee merged 136 commits into
mainfrom
python-kms-migration
Nov 14, 2022
ConversationCommits (136)ChecksFiles changed
Merged

migrate code from googleapis/python-kms#8470
dandhlee merged 136 commits into
mainfrom
python-kms-migration

Conversation

rsamborski commented Nov 8, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Samples migration from https://github.com/googleapis/python-kms

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

product-auto-label Bot added the samples Issues that are directly related to samples. label Nov 8, 2022

google-cla Bot commented Nov 8, 2022

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

rsamborski force-pushed the python-kms-migration branch from 49ce0d2 to 02ca4d2 Compare November 8, 2022 22:13
rsamborski self-assigned this Nov 8, 2022
rsamborski added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 8, 2022
rsamborski marked this pull request as ready for review November 8, 2022 22:14
rsamborski requested review from a team as code owners November 8, 2022 22:14

snippet-bot Bot commented Nov 8, 2022 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 42 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

dandhlee requested a review from nicain November 8, 2022 22:31

dandhlee commented Nov 8, 2022

Copy link
Copy Markdown
Collaborator

Nick, could you help take a look for this migration?

kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 8, 2022
rsamborski commented Nov 8, 2022
View reviewed changes
Comment thread .github/CODEOWNERS
dandhlee reviewed Nov 8, 2022
View reviewed changes
Comment thread .github/CODEOWNERS
Comment thread kms/attestations/noxfile.py Outdated
Comment thread kms/snippets/noxfile.py Outdated
chalmerlowe approved these changes Nov 10, 2022
View reviewed changes

chalmerlowe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

rsamborski requested a review from dandhlee November 11, 2022 22:19
dandhlee requested changes Nov 11, 2022
View reviewed changes

dandhlee left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could you also add blunderbuss.yml for api: cloudkms?

ryanmats and others added 12 commits November 14, 2022 11:30
Python KMS Apiary P1 samples [(#779)](#779)
c3dae48 
* Draft of first half of KMS samples

* reversed wrong change

* KMS Apiary Python samples - P1

* Few minor style issues

* Adding back in space i accidentally deleted

* Addressed all code review comments

* Renamed api directory to api-client

* Addressed more code review comments

* Formatting change

* Fix quickstart test

Change-Id: Ib79dc1345c9c40547f3fd4e9c3c9a48963a3b399

* Update readme

Change-Id: Icf4a66083f56d6f51be76ba1cf3b5dc8daf2c4c1

* Add readme

Change-Id: I2fbaa55092ef8787f1423d499aa310cab258c0c1

* Added parsers

* Final minor changes to parsers

* Added autogenerated README

* Changed snippets_test keyring name and cryptokey name
random generation of keyring / cryptokey names [(#786)](#786)
c031a34 
* random generation of keyring / cryptokey names

* Fixed formatting of keyring name and cryptokey name
Auto-update dependencies. [(#790)](#790)
cc8e1b4
Remove usage of GoogleCredentials [(#810)](#810)
7147ccf
Updates Could-KMS sample code to use V1 libraries. [(#856)](#856)
69a7649
Remove cloud config fixture [(#887)](#887)
e67c399 
* Remove cloud config fixture

* Fix client secrets

* Fix bigtable instance
Re-generate all readmes
5b298d5
KMS: Clean up base64 logic in the encrypt and decrypt functions. [(#1074
480435a 
)](#1074)

The use of base64 is essentially an implementation detail of the Cloud KMS REST
API: it is required only so that arbitrary binary data can be included in a JSON
string, which only allows Unicode characters. Therefore, the "encrypt" sample
function should decode the base64-encoded ciphertext before writing the
file. Similarly, "decrypt" should not assume that an input file is
base64-encoded, but should perform the base64-encoding itself before sending the
encrypted data to KMS.

This aligns with how the "gcloud kms encrypt" and "gcloud kms decrypt" commands
behave. See https://stackoverflow.com/q/45699472 for an example of user
confusion caused by the mismatch.
KMS: Make the samples consistent with the other languages. [(#1075)](#…
adefefe 
…1075)

In particular, this change:
- changes to use a consistent "_id" suffix for resource name components
- uses "data" instead of "text", since encryption is not restricted to text
- substitutes "ciphertext" for "encrypted {text, data}"
- spells "crypto key" and "key ring" each as two separate words, as in the API

Tracking bug: http://b/64758639
Auto-update dependencies. [(#1094)](#1094)
b97884f 
* Auto-update dependencies.

* Relax assertions in the ocr_nl sample

Change-Id: I6d37e5846a8d6dd52429cb30d501f448c52cbba1

* Drop unused logging apiary samples

Change-Id: I545718283773cb729a5e0def8a76ebfa40829d51
Update all generated readme auth instructions [(#1121)](#1121)
38d062d 
Change-Id: I03b5eaef8b17ac3dc3c0339fd2c7447bd3e11bd2
Auto-update dependencies. [(#1133)](#1133)
832a6be 
* Auto-update dependencies.

* Fix missing http library

Change-Id: I99faa600f2f3f1f50f57694fc9835d7f35bda250
renovate-bot and others added 20 commits November 14, 2022 11:30
chore(deps): update dependency cryptography to v37.0.1 (#273)
e897dad
chore(deps): update dependency cryptography to v37.0.2 (#274)
1ae0ad3
fix: require python 3.7+ (#313)
f392f41 
* chore(python): drop python 3.6

Source-Link: googleapis/synthtool@4f89b13
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c

* add api_description to .repo-metadata.json

* require python 3.7+ in setup.py

* remove python 3.6 sample configs

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
chore(deps): update all dependencies (#303)
d5a2f11 
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
chore(deps): update all dependencies (#319)
a91c0cf 
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
chore(deps): update dependency google-cloud-kms to v2.12.1 (#326)
955d67e
chore(deps): update dependency pytest to v7.1.3 (#338)
f9e23a0
chore(deps): update dependency cryptography to v38 (#339)
ba0fe23
chore(deps): update dependency cryptography to v38.0.1 (#341)
040450d
chore: detect samples tests in nested directories (#345)
181e085 
Source-Link: googleapis/synthtool@50db768
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e09366bdf0fd9c8976592988390b24d53583dd9f002d476934da43725adbb978
chore(deps): update dependency google-cloud-kms to v2.12.2 (#349)
74d51f2
chore(deps): update all dependencies (#352)
b9d6082
chore(deps): update dependency pytest to v7.2.0 (#353)
e1e35bf
Updates to READMEs and CODEOWNERS
40dfca1
Update requirements.txt to include requests module
81dd63a
License header updates and region tag rename
73b0204
Fix CODEOWNERS newline at the end of file
062ea7c
Removed noxfile.py and added noxfile_config.py
b735728
Turn off type hints enforcing for old samples
0fa2468
Turn off type hints enforcing for old samples
5b8496c

rsamborski commented Nov 14, 2022

Copy link
Copy Markdown
Member Author

Could you also add blunderbuss.yml for api: cloudkms?

@dandhlee Done.

rsamborski requested a review from dandhlee November 14, 2022 10:34
dandhlee requested changes Nov 14, 2022
View reviewed changes
Comment thread .github/blunderbuss.yml
rsamborski requested a review from dandhlee November 14, 2022 14:00
dandhlee approved these changes Nov 14, 2022
View reviewed changes

dandhlee left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you! Overriding CLA and merging.

dandhlee merged commit 88cf2fe into main Nov 14, 2022
dandhlee deleted the python-kms-migration branch November 14, 2022 20:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

chalmerlowe chalmerlowe approved these changes
dandhlee dandhlee approved these changes
nicain Awaiting requested review from nicain

Assignees

rsamborski

Labels

samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL