FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Natural Language GAPIC client library by dizcology · Pull Request #1018 · GoogleCloudPlatform/python-docs-samples · GitHub

/ python-docs-samples Public

Natural Language GAPIC client library - #1018

Merged
theacodes merged 16 commits into
GoogleCloudPlatform:masterfrom
dizcology:language_gapic
Jul 28, 2017
ConversationCommits (16)ChecksFiles changed
Merged

Natural Language GAPIC client library#1018
theacodes merged 16 commits into
GoogleCloudPlatform:masterfrom
dizcology:language_gapic

Conversation

dizcology commented Jul 12, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

migrate samples to natural language gapic client library

Merge only after the client library has been released and tested.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 12, 2017
dizcology changed the title migrate samples to natural language gapic client library Natural Language GAPIC client library Jul 12, 2017
theacodes reviewed Jul 13, 2017
View reviewed changes
Comment thread language/cloud-client/v1beta2/snippets.py Outdated

theacodes Jul 13, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

can you not use the enums here (should be types.EncodingType.UTF32?

dizcology Jul 20, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

removing encoding, since it is no longer needed: https://github.com/googleapis/googleapis/pull/408

dizcology Jul 28, 2017 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

turns out we should still keep the encoding (added back)

The client libraries are current designed to have all enums in the enums module, such as google.cloud.language.enums.

theacodes commented Jul 13, 2017

Copy link
Copy Markdown
Contributor

This LGTM, but you need to resolve the conflicts first.

dizcology commented Jul 28, 2017

Copy link
Copy Markdown
Member Author

client library version 0.26.1 released, and tested against the updated samples.

theacodes merged commit 7c3bebd into GoogleCloudPlatform:master Jul 28, 2017
busunkim96 pushed a commit to busunkim96/python-language that referenced this pull request May 20, 2020
Natural Language GAPIC client library [(#1018)](GoogleCloudPlatform/p…
d79470d 
…ython-docs-samples#1018)
hkdevandla pushed a commit to hkdevandla/python-language that referenced this pull request Sep 26, 2020
Natural Language GAPIC client library [(#1018)](GoogleCloudPlatform/p…
a56d438 
…ython-docs-samples#1018)
busunkim96 pushed a commit to googleapis/python-language that referenced this pull request Sep 29, 2020
Natural Language GAPIC client library [(#1018)](GoogleCloudPlatform/p…
c74ec4c 
…ython-docs-samples#1018)
m-strzelczyk pushed a commit that referenced this pull request Nov 18, 2022
Natural Language GAPIC client library [(#1018)](#1018)
3399655
m-strzelczyk mentioned this pull request Nov 18, 2022
Merged
8 tasks
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Jul 6, 2023
Natural Language GAPIC client library [(#1018)](GoogleCloudPlatform/p…
1b20402 
…ython-docs-samples#1018)
chalmerlowe mentioned this pull request Apr 7, 2026
Merged
9 tasks
chalmerlowe pushed a commit that referenced this pull request Apr 7, 2026
chore(deps): update dependency pytest to v7.3.1 (#1018)
4c8bbd0 
Co-authored-by: cojenco <cathyo@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
theacodes theacodes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL