FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Print all results, not all alternatives by jerjou · Pull Request #1098 · GoogleCloudPlatform/python-docs-samples · GitHub

/ python-docs-samples Public

Print all results, not all alternatives - #1098

Merged
jerjou merged 1 commit into
masterfrom
speech-results
Sep 7, 2017
ConversationCommits (1)ChecksFiles changed
Merged

Print all results, not all alternatives#1098
jerjou merged 1 commit into
masterfrom
speech-results

Conversation

jerjou commented Aug 31, 2017

Copy link
Copy Markdown
Contributor

No description provided.

jerjou requested review from dizcology and theacodes August 31, 2017 17:51
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 31, 2017
jerjou changed the title py35(sample='./speech/cloud-client')Print all results, not all alternatives Print all results, not all alternatives Sep 1, 2017
dizcology reviewed Sep 4, 2017
View reviewed changes
Comment thread speech/cloud-client/transcribe_streaming_mic.py
# There could be multiple results in each response.
# The `results` list is consecutive. For streaming, we only care about
# the first result being considered, since once it's `is_final`, it
# moves on to considering the next utterance.

dizcology Sep 4, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Does this mean that there is always only one result in each response of streaming_recognize?

jerjou Sep 5, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

a) What're you doing doing a code review on a holiday?? tsk tsk
b) Mm... if interim_results is False, then yes - there will only be one result. But if interim_results is True, then there can be 0 or one is_final result, followed by 0 to many interim (is_final=False) results. I believe different results correspond to consecutive parts of the audio stream. See here

dizcology Sep 7, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I see - thanks for the clarification.

dizcology approved these changes Sep 7, 2017
View reviewed changes

dizcology left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me 👍

Comment thread speech/cloud-client/transcribe_streaming_mic.py
# There could be multiple results in each response.
# The `results` list is consecutive. For streaming, we only care about
# the first result being considered, since once it's `is_final`, it
# moves on to considering the next utterance.

dizcology Sep 7, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I see - thanks for the clarification.

jerjou merged commit cfa07e8 into master Sep 7, 2017
jerjou deleted the speech-results branch September 7, 2017 17:27
busunkim96 pushed a commit to busunkim96/python-speech that referenced this pull request Sep 1, 2020
Print all results, not all alternatives [(#1098)](GoogleCloudPlatform…
a68a8d6 
…/python-docs-samples#1098)
busunkim96 pushed a commit to googleapis/python-speech that referenced this pull request Sep 3, 2020
Print all results, not all alternatives [(#1098)](GoogleCloudPlatform…
5fd8742 
…/python-docs-samples#1098)
telpirion pushed a commit that referenced this pull request Jan 13, 2023
Print all results, not all alternatives [(#1098)](#1098)
ca29935
telpirion mentioned this pull request Jan 13, 2023
Merged
8 tasks
dandhlee pushed a commit that referenced this pull request Feb 9, 2023
Print all results, not all alternatives [(#1098)](#1098)
ebdaece
telpirion pushed a commit that referenced this pull request Mar 13, 2023
Print all results, not all alternatives [(#1098)](#1098)
17e0759
atulep pushed a commit to googleapis/google-cloud-python that referenced this pull request Apr 6, 2023
Print all results, not all alternatives [(#1098)](GoogleCloudPlatform…
5a3a490 
…/python-docs-samples#1098)
atulep pushed a commit to googleapis/google-cloud-python that referenced this pull request Apr 6, 2023
Print all results, not all alternatives [(#1098)](GoogleCloudPlatform…
9cb328a 
…/python-docs-samples#1098)
atulep pushed a commit to googleapis/google-cloud-python that referenced this pull request Apr 18, 2023
Print all results, not all alternatives [(#1098)](GoogleCloudPlatform…
8918c35 
…/python-docs-samples#1098)
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 22, 2023
Print all results, not all alternatives [(#1098)](GoogleCloudPlatform…
e5f3a9d 
…/python-docs-samples#1098)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dizcology dizcology approved these changes
theacodes Awaiting requested review from theacodes

Assignees

dizcology

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL