FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add AlloyDB ScaNN benchmark notebook on GloVe-100 by rishwithag · Pull Request #14495 · GoogleCloudPlatform/python-docs-samples · GitHub

/ python-docs-samples Public

Add AlloyDB ScaNN benchmark notebook on GloVe-100 - #14495

Merged
vinay0410 merged 6 commits into
GoogleCloudPlatform:mainfrom
rishwithag:add-alloydb-scann-benchmark-glove
Aug 17, 2026
ConversationCommits (6)ChecksFiles changed
Merged

Add AlloyDB ScaNN benchmark notebook on GloVe-100#14495
vinay0410 merged 6 commits into
GoogleCloudPlatform:mainfrom
rishwithag:add-alloydb-scann-benchmark-glove

Conversation

rishwithag commented Aug 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fixes #

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.

Compliance & Style

Post-Approval Actions

  • Please merge this PR for me once it is approved

rishwithag requested review from a team as code owners August 11, 2026 10:51
product-auto-label Bot added api: alloydb Issues related to the AlloyDB API. samples Issues that are directly related to samples. api: notebooks Issues related to the Agent Platform Workbench API. labels Aug 11, 2026
gemini-code-assist Bot reviewed Aug 11, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request introduces a new Jupyter notebook benchmarking the vector search performance (Recall vs QPS) of AlloyDB ScaNN in Auto Mode using the GloVe-100 Angular dataset. The review feedback highlights several critical security and reliability improvements, including addressing SQL injection risks by parameterizing queries in data ingestion and benchmark execution, switching to HTTPS for secure dataset downloads, and adding a network timeout to prevent indefinite hangs during download.

Comment thread alloydb/notebooks/alloydb_scann_benchmark_glove.ipynb Outdated
Comment thread alloydb/notebooks/alloydb_scann_benchmark_glove.ipynb Outdated
Comment thread alloydb/notebooks/alloydb_scann_benchmark_glove.ipynb Outdated
Comment thread alloydb/notebooks/alloydb_scann_benchmark_glove.ipynb Outdated
Comment thread alloydb/notebooks/alloydb_scann_benchmark_glove.ipynb Outdated
rishwithag changed the title feat(alloydb): add AlloyDB ScaNN benchmark notebook on GloVe-100 Add AlloyDB ScaNN benchmark notebook on GloVe-100 Aug 11, 2026
shrikantawate-gcp approved these changes Aug 17, 2026
View reviewed changes

shrikantawate-gcp left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Added one comment

Comment thread alloydb/notebooks/alloydb_scann_benchmark_glove.ipynb
vinay0410 merged commit 2eac113 into GoogleCloudPlatform:main Aug 17, 2026
10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

shrikantawate-gcp shrikantawate-gcp approved these changes
+1 more reviewer
gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: alloydb Issues related to the AlloyDB API. api: notebooks Issues related to the Agent Platform Workbench API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL