FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

refactor(generativeai/embeddings/multimodal): Remove deprecated embeddings multimodal files by Kef131 · Pull Request #14523 · GoogleCloudPlatform/python-docs-samples · GitHub

/ python-docs-samples Public

refactor(generativeai/embeddings/multimodal): Remove deprecated embeddings multimodal files - #14523

Merged
Kef131 merged 3 commits into
mainfrom
refactor(embedding/multimodal)_remove_deprecated_multimodal_image_video_samples
Aug 20, 2026
ConversationCommits (3)ChecksFiles changed
Merged

refactor(generativeai/embeddings/multimodal): Remove deprecated embeddings multimodal files#14523
Kef131 merged 3 commits into
mainfrom
refactor(embedding/multimodal)_remove_deprecated_multimodal_image_video_samples

Conversation

Kef131 commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #
b/546136656

  • Deleted the multimodal_image_example.py file, which contained sample code for generating multimodal embeddings from images and text.
  • Deleted the multimodal_video_example.py file, which contained sample code for generating embeddings from video content.

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.

Compliance & Style

Post-Approval Actions

  • Please merge this PR for me once it is approved

product-auto-label Bot added the samples Issues that are directly related to samples. label Aug 18, 2026
gemini-code-assist Bot reviewed Aug 18, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request removes the multimodal image and video embedding example files, along with their corresponding unit tests in generative_ai/embeddings/test_embeddings_examples.py. Feedback points out that the unused imports for these deleted modules must also be removed from the top of the test file to prevent a ModuleNotFoundError when running the test suite.

Comment thread generative_ai/embeddings/test_embeddings_examples.py
Kef131 self-assigned this Aug 18, 2026
Kef131 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 19, 2026
XrossFox approved these changes Aug 19, 2026
View reviewed changes

XrossFox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

Kef131 marked this pull request as ready for review August 19, 2026 21:43
Kef131 requested review from a team as code owners August 19, 2026 21:43

snippet-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Kef131 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 20, 2026
amcolin approved these changes Aug 20, 2026
View reviewed changes

amcolin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Kef131 merged commit 683bf45 into main Aug 20, 2026
15 of 23 checks passed
Kef131 deleted the refactor(embedding/multimodal)_remove_deprecated_multimodal_image_video_samples branch August 20, 2026 18:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

XrossFox XrossFox approved these changes
amcolin amcolin approved these changes
+1 more reviewer
gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

Kef131

Labels

samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL