FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(generative_ai): remove samples migrated to genai by XrossFox · Pull Request #14531 · GoogleCloudPlatform/python-docs-samples · GitHub

/ python-docs-samples Public

chore(generative_ai): remove samples migrated to genai - #14531

Merged
holtskinner merged 1 commit into
GoogleCloudPlatform:mainfrom
XrossFox:vertex-to-genai-vision-models-cleaning
Aug 24, 2026
ConversationCommits (1)ChecksFiles changed
Merged

chore(generative_ai): remove samples migrated to genai#14531
holtskinner merged 1 commit into
GoogleCloudPlatform:mainfrom
XrossFox:vertex-to-genai-vision-models-cleaning

Conversation

XrossFox commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Description

Deletes embeddings and model tuning examples that have been migrated to use the new google-genai SDK.

Fixes b/540949366

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.

Compliance & Style

Post-Approval Actions

  • Please merge this PR for me once it is approved

product-auto-label Bot added the samples Issues that are directly related to samples. label Aug 21, 2026
gemini-code-assist Bot reviewed Aug 21, 2026
View reviewed changes

gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Code Review

This pull request removes several Python example files, tests, and configuration files related to Vertex AI text/multimodal embeddings and supervised tuning. Specifically, it deletes code examples for batch text embedding, lower-dimension embeddings, multimodal embeddings, and tuning job cancellation, along with their corresponding test suites and dependency requirements. There are no review comments, so we have no feedback to provide.

chore(generative_ai): remove samples migrated to genai
dc227de 
 Deletes embeddings and model tuning examples that have been migrated to use the new `google-genai` SDK.
XrossFox force-pushed the vertex-to-genai-vision-models-cleaning branch from f2de68d to dc227de Compare August 21, 2026 16:29
angelcaamal approved these changes Aug 21, 2026
View reviewed changes

angelcaamal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I didn't find any references to the deleted samples on DevSite, LGTM!

angelcaamal approved these changes Aug 24, 2026
View reviewed changes

angelcaamal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I couldn't find any references in use for this sample in devsite, LGTM

XrossFox marked this pull request as ready for review August 24, 2026 17:12
XrossFox requested review from a team as code owners August 24, 2026 17:12

snippet-bot Bot commented Aug 24, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

XrossFox closed this Aug 24, 2026
XrossFox deleted the vertex-to-genai-vision-models-cleaning branch August 24, 2026 17:18
XrossFox restored the vertex-to-genai-vision-models-cleaning branch August 24, 2026 18:33
XrossFox reopened this Aug 24, 2026
amcolin approved these changes Aug 24, 2026
View reviewed changes

amcolin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

holtskinner merged commit 25bbbcb into GoogleCloudPlatform:main Aug 24, 2026
16 of 24 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Kef131 Kef131 approved these changes
holtskinner holtskinner approved these changes
amcolin amcolin approved these changes
angelcaamal angelcaamal approved these changes
+1 more reviewer
gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL