FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix PubSub client conflict by bgsouza · Pull Request #1551 · GoogleCloudPlatform/python-docs-samples · GitHub

Fix PubSub client conflict - #1551

Closed
bgsouza wants to merge 2 commits into
GoogleCloudPlatform:masterfrom
bgsouza:patch-1
Closed

Fix PubSub client conflict#1551
bgsouza wants to merge 2 commits into
GoogleCloudPlatform:masterfrom
bgsouza:patch-1

Conversation

bgsouza commented Jul 5, 2018

Copy link
Copy Markdown

Correcting the requirements.txt file conflict to proceed with the installation
$ pip install -r requirements.txt

Correcting the requirements.txt file conflict to proceed with the installation
$ pip install -r requirements.txt

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jul 5, 2018

Copy link
Copy Markdown

@bgsouza did you want to sign the CLA so this can merge and fix #1550 ?

bgsouza commented Jul 16, 2018
edited
Loading

Copy link
Copy Markdown
Author

@techieshark Yes! how can I do this?
I already did my registration to get the cla 'but do not know how to "re-process" here on GitHub

Copy link
Copy Markdown

CLAs look good, thanks!

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jul 16, 2018
bgsouza closed this Jul 16, 2018
bgsouza reopened this Jul 16, 2018

Copy link
Copy Markdown

@bgsouza super, looks like that worked, now we just need someone (w/ write access) to review and merge.

0x5d commented Aug 2, 2018

Copy link
Copy Markdown

Hi! Any progress on this? I'd love to see this fix merged.

bgsouza commented Aug 5, 2018

Copy link
Copy Markdown
Author

Hi @castillobgr, not yet :(
I am awaiting authorization for merge

bgsouza left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi, I made a small fix on this file as it was breaking execution with python2

bgsouza left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

fix version conflict

bgsouza left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

please review this commit

Copy link
Copy Markdown

It seems that master has been updated outside of this PR, but with the effect of fixing the issue - see https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/pubsub/cloud-client/requirements.txt

Should we close this?

bgsouza closed this Sep 12, 2018
bgsouza deleted the patch-1 branch September 12, 2018 14:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL