Add Cloud Scheduler sample - #1968
Merged
averikitsch merged 14 commits intoJul 24, 2019
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
gguuss
approved these changes
Jul 24, 2019
gguuss
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, a few optional comments.
Sorry, something went wrong.
Comment thread
scheduler/create_job_test.py
Outdated
|
|
||
|
|
||
| def test_create_job(capsys): | ||
| create_result = create_job.create_scheduler_job(TEST_PROJECT_ID, |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Consider removing the hanging indent:
create_result = create_job.create_scheduler_job(
TEST_PROJECT_ID, TEST_LOCATION, 'my-service')
Sorry, something went wrong.
Comment thread
scheduler/main.py
Outdated
| @@ -0,0 +1,42 @@ | |||
| # Copyright 2018 Google LLC | |||
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
(Optional) Consider updating to 2019 as this is first publish
Sorry, something went wrong.
danoscarmike
pushed a commit
to danoscarmike/python-scheduler
that referenced
this pull request
Aug 19, 2020
…samples#1968) * scheduler sample * scheduler tutorial draft * create and delete requests completed * updated region tag * update error * fix linting * Update styling * Update license * Update license * Update license * Update license
busunkim96
pushed a commit
to googleapis/python-scheduler
that referenced
this pull request
Aug 20, 2020
…samples#1968) * scheduler sample * scheduler tutorial draft * create and delete requests completed * updated region tag * update error * fix linting * Update styling * Update license * Update license * Update license * Update license
MiaCY
pushed a commit
that referenced
this pull request
Apr 11, 2023
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Apr 22, 2023
parthea
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Sep 22, 2023
…samples#1968) * scheduler sample * scheduler tutorial draft * create and delete requests completed * updated region tag * update error * fix linting * Update styling * Update license * Update license * Update license * Update license
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.