dialogflow: remove unused samples + tests - #3249
Merged
tmatsuo merged 19 commits intoApr 23, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…ng intent with model selection
… entity type management and entity type management
…ge base management
Strykrol
requested review from
a team,
nnegrey,
sirtorry and
telpirion
as code owners
April 1, 2020 20:00
tmatsuo
approved these changes
Apr 20, 2020
nnegrey
approved these changes
Apr 23, 2020
Copy link
Copy Markdown
Contributor
|
@Strykrol Here is the lint output: ./document_management.py:34:1: E302 expected 2 blank lines, found 1
def create_document(project_id, knowledge_base_id, display_name, mime_type,
^
./document_management.py:73:1: E305 expected 2 blank lines after class or function definition, found 1
if __name__ == '__main__':
^
./document_management.py:113:42: W292 no newline at end of file
args.content_uri) ^
./knowledge_base_management.py:70:66: W292 no newline at end of file
create_knowledge_base(args.project_id, args.display_name) ^
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Got it, fixing... |
Sorry, something went wrong.
gguuss
approved these changes
Apr 23, 2020
Copy link
Copy Markdown
Contributor
|
A flake filed: #3490 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@Strykrol Thanks! It's finally merged :) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thank you for taking it to the finish line! |
Sorry, something went wrong.
busunkim96
pushed a commit
to busunkim96/dialogflow-python-client-v2
that referenced
this pull request
Nov 30, 2020
…rm/python-docs-samples#3249) * dialogflow: delete unused samples and corresponding tests for context management * dialogflow: delete unused samples and corresponding tests for detecting intent with model selection * dialogflow: delete unused samples for document management * dialogflow: clean up document management whitespace * dialogflow: delete unused samples for entity management * dialogflow: delete tests for deleted entity management samples * dialogflow: delete tests for deleted document management samples * dialogflow: delete unused samples and corresponding tests for entity type management * dialogflow: delete unused samples and corresponding tests for session entity type management and entity type management * dialogflow: delete unused samples and corresponding tests for knowledge base management * flake8 lints Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
busunkim96
pushed a commit
to googleapis/python-dialogflow
that referenced
this pull request
Dec 9, 2020
…rm/python-docs-samples#3249) * dialogflow: delete unused samples and corresponding tests for context management * dialogflow: delete unused samples and corresponding tests for detecting intent with model selection * dialogflow: delete unused samples for document management * dialogflow: clean up document management whitespace * dialogflow: delete unused samples for entity management * dialogflow: delete tests for deleted entity management samples * dialogflow: delete tests for deleted document management samples * dialogflow: delete unused samples and corresponding tests for entity type management * dialogflow: delete unused samples and corresponding tests for session entity type management and entity type management * dialogflow: delete unused samples and corresponding tests for knowledge base management * flake8 lints Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
telpirion
pushed a commit
that referenced
this pull request
Jan 18, 2023
* dialogflow: delete unused samples and corresponding tests for context management * dialogflow: delete unused samples and corresponding tests for detecting intent with model selection * dialogflow: delete unused samples for document management * dialogflow: clean up document management whitespace * dialogflow: delete unused samples for entity management * dialogflow: delete tests for deleted entity management samples * dialogflow: delete tests for deleted document management samples * dialogflow: delete unused samples and corresponding tests for entity type management * dialogflow: delete unused samples and corresponding tests for session entity type management and entity type management * dialogflow: delete unused samples and corresponding tests for knowledge base management * flake8 lints Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
8 tasks
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Feb 6, 2023
* dialogflow: delete unused samples and corresponding tests for context management * dialogflow: delete unused samples and corresponding tests for detecting intent with model selection * dialogflow: delete unused samples for document management * dialogflow: clean up document management whitespace * dialogflow: delete unused samples for entity management * dialogflow: delete tests for deleted entity management samples * dialogflow: delete tests for deleted document management samples * dialogflow: delete unused samples and corresponding tests for entity type management * dialogflow: delete unused samples and corresponding tests for session entity type management and entity type management * dialogflow: delete unused samples and corresponding tests for knowledge base management * flake8 lints Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
telpirion
pushed a commit
that referenced
this pull request
Mar 13, 2023
* dialogflow: delete unused samples and corresponding tests for context management * dialogflow: delete unused samples and corresponding tests for detecting intent with model selection * dialogflow: delete unused samples for document management * dialogflow: clean up document management whitespace * dialogflow: delete unused samples for entity management * dialogflow: delete tests for deleted entity management samples * dialogflow: delete tests for deleted document management samples * dialogflow: delete unused samples and corresponding tests for entity type management * dialogflow: delete unused samples and corresponding tests for session entity type management and entity type management * dialogflow: delete unused samples and corresponding tests for knowledge base management * flake8 lints Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
vchudnov-g
pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Sep 20, 2023
…rm/python-docs-samples#3249) * dialogflow: delete unused samples and corresponding tests for context management * dialogflow: delete unused samples and corresponding tests for detecting intent with model selection * dialogflow: delete unused samples for document management * dialogflow: clean up document management whitespace * dialogflow: delete unused samples for entity management * dialogflow: delete tests for deleted entity management samples * dialogflow: delete tests for deleted document management samples * dialogflow: delete unused samples and corresponding tests for entity type management * dialogflow: delete unused samples and corresponding tests for session entity type management and entity type management * dialogflow: delete unused samples and corresponding tests for knowledge base management * flake8 lints Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.