Adding async sample code to cloud speech. - #404
Merged
theacodes merged 3 commits intoJul 6, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
speech/api/speech_async_grpc.py
Outdated
| import time | ||
|
|
||
| from gcloud.credentials import get_credentials | ||
| from google.cloud.speech.v1beta1 import cloud_speech_pb2 as cloud_speech |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
In general I don't recommend aliasing imports. Is this a standard grpc practice?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Looking pretty good, just a few nits @xinjiez. Please ping when you're ready for another review. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Done. PTAL. Thanks. |
Sorry, something went wrong.
Comment thread
speech/api/speech_async_grpc.py
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Since this is only used in one place, can you put it there?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Updated. Thanks Jon. |
Sorry, something went wrong.
theacodes
pushed a commit
that referenced
this pull request
Jul 11, 2016
8 tasks
telpirion
pushed a commit
that referenced
this pull request
Jan 13, 2023
* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
8 tasks
telpirion
pushed a commit
that referenced
this pull request
Jan 18, 2023
* docs(samples): adds training phrases sample * docs(samples): fixed lint * docs(samples): ignored auto-foratting Co-authored-by: Anthonios Partheniou <partheniou@google.com>
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Feb 6, 2023
* docs(samples): adds training phrases sample * docs(samples): fixed lint * docs(samples): ignored auto-foratting Co-authored-by: Anthonios Partheniou <partheniou@google.com>
dandhlee
pushed a commit
that referenced
this pull request
Feb 9, 2023
* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
telpirion
pushed a commit
that referenced
this pull request
Mar 13, 2023
* docs(samples): adds training phrases sample * docs(samples): fixed lint * docs(samples): ignored auto-foratting Co-authored-by: Anthonios Partheniou <partheniou@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.