Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
appengine/flexible/redis/main.py
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
extra newline?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Fixed.
Sorry, something went wrong.
added 2 commits
July 7, 2016 12:43
Change-Id: I1593cb4b0a3032da21d70c2fcbc6b0e466d6b2ca
Change-Id: I4a37c5e2ce724ef2b130f76a97ca999aebec0d01
Comment thread
appengine/flexible/redis/main_test.py
|
|
||
| def test_index(): | ||
| try: | ||
| main.redis_client.set('counter', 0) |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Do we have a context in which this is actually running?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Yeah I'm about to push a commit to enable it on travis.
Sorry, something went wrong.
Change-Id: Ia6a094ddc5c71ddb286ec55d957753570e4ec4f3
Copy link
Copy Markdown
Contributor
|
lgtm |
Sorry, something went wrong.
Change-Id: I27a2798349373307711a842ede87f4d015bcda4b
Copy link
Copy Markdown
Contributor
Author
|
@waprin thanks for the swift review. Will merge once the tests for the test god pass. |
Sorry, something went wrong.
msampathkumar
pushed a commit
that referenced
this pull request
Nov 14, 2022
* chore(deps): update all dependencies * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * revert Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
8 tasks
msampathkumar
pushed a commit
that referenced
this pull request
Nov 14, 2022
Source-Link: googleapis/synthtool@1b71c10 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:00c9d764fd1cd56265f12a5ef4b99a0c9e87cf261018099141e2ca5158890416 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
8 tasks
8 tasks
telpirion
pushed a commit
that referenced
this pull request
Jan 18, 2023
8 tasks
dandhlee
pushed a commit
that referenced
this pull request
Feb 6, 2023
telpirion
pushed a commit
that referenced
this pull request
Mar 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.