FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add samples for natural language api. by jerjou · Pull Request #425 · GoogleCloudPlatform/python-docs-samples · GitHub

/ python-docs-samples Public

Add samples for natural language api. - #425

Merged
jerjou merged 10 commits into
masterfrom
nl
Jul 20, 2016
ConversationCommits (10)ChecksFiles changed
Merged

Add samples for natural language api.#425
jerjou merged 10 commits into
masterfrom
nl

Conversation

jerjou commented Jul 19, 2016

Copy link
Copy Markdown
Contributor

No description provided.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 19, 2016
jerjou force-pushed the nl branch 3 times, most recently from 71822d8 to 4f07e8c Compare July 20, 2016 00:01
waprin reviewed Jul 20, 2016
View reviewed changes
Comment thread conftest.py Outdated

waprin Jul 20, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

unrelated to PR but shouldn't Namespace inherit from object?

jerjou commented Jul 20, 2016

Copy link
Copy Markdown
Contributor Author

Updated.

waprin reviewed Jul 20, 2016
View reviewed changes
Comment thread language/api/README.md Outdated

waprin Jul 20, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

does gcloud beta auth application-default login not work btw?

jerjou Jul 20, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Not sure. See my comment here, though..

waprin reviewed Jul 20, 2016
View reviewed changes
Comment thread language/movie_nl/README.md Outdated

waprin Jul 20, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

first of all, better to put \ at end of each line to make easier copy paste.

secondly I get

TypeError: coercing to Unicode: need string or buffer, NoneType found

waprin reviewed Jul 20, 2016
View reviewed changes
Comment thread language/ocr_nl/README.md Outdated

waprin Jul 20, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This one also requires you to enable Visino API.

waprin commented Jul 20, 2016

Copy link
Copy Markdown
Contributor

Ok we can nitpick code later but I'm fine to merge once TypeError: coercing to Unicode: need string or buffer, NoneType found issue is fixed

waprin commented Jul 20, 2016

Copy link
Copy Markdown
Contributor

And note about enabling Vision API

jerjou force-pushed the nl branch 3 times, most recently from 4729fa0 to 04eac7d Compare July 20, 2016 01:26
Add samples for natural language api.
5fb9def 
Change-Id: I089b244f1a0a2210fffab6f5747eed9f6150147a
puneithk and others added 8 commits July 19, 2016 19:06
logged error message with exception
03cb67b 
Change-Id: I8ff59d08f2ae8ce4cb3dd0b57b3548db3d5b8add
fixed variable unused error
e2cc3d5 
Change-Id: I1367429c3ceaefd0b0d36d9d7cad6ca29cbfdd2d
Refactor for clarity.
1789677 
Change-Id: Iecc1327db4aa21eb5ee61ce58bba3d142e600734
cast samples to int
1242524 
Change-Id: I33a6c3259dc5a9b0cc1ad081cd57acc452fc6b1a
added sample variable
3e4deb1 
Change-Id: Ic2b721f775601d2dfb718be26d425e7c2e91eb8a
fixed indentation bug
4ffc546 
Change-Id: I2eac2d41e3f8d96c1d049dbbc7b48c96d5fded0a
Fix lint errors
7ca9918 
Change-Id: I026963be93ca3ef776420807e14abdcfcc5fe95f
Remove movie_nl sample until it's more stable.
0be30eb 
Change-Id: Iab58378f40c760e88f2b3cc0806985894ce77e76

jerjou commented Jul 20, 2016

Copy link
Copy Markdown
Contributor Author

Merging - we'll add the movie_nl sample in a separate PR

jerjou merged commit bd7a093 into master Jul 20, 2016
engelke pushed a commit that referenced this pull request Nov 28, 2022
feat: Add SavedQuery CURD support (#425)
e96234a 
- [ ] Regenerate this pull request now.

feat: Add tags support
feat: Add RelatedAsset and deprecate RelatedAssets for relationship GA

*The previous representation of the relationship feature is deprecated and unimplemented. The RelatedAsset message represents the new stable format.

PiperOrigin-RevId: 449306805

Source-Link: googleapis/googleapis@3d7bd9d

Source-Link: https://github.com/googleapis/googleapis-gen/commit/71a93d05d6076271d04b7592f7fad0d3f0c7a040
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzFhOTNkMDVkNjA3NjI3MWQwNGI3NTkyZjdmYWQwZDNmMGM3YTA0MCJ9
dandhlee pushed a commit that referenced this pull request Nov 29, 2022
feat: Add SavedQuery CURD support (#425)
bbe2d8e 
- [ ] Regenerate this pull request now.

feat: Add tags support
feat: Add RelatedAsset and deprecate RelatedAssets for relationship GA

*The previous representation of the relationship feature is deprecated and unimplemented. The RelatedAsset message represents the new stable format.

PiperOrigin-RevId: 449306805

Source-Link: googleapis/googleapis@3d7bd9d

Source-Link: googleapis/googleapis-gen@71a93d0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNzFhOTNkMDVkNjA3NjI3MWQwNGI3NTkyZjdmYWQwZDNmMGM3YTA0MCJ9
telpirion mentioned this pull request Jan 18, 2023
Closed
8 tasks
telpirion pushed a commit that referenced this pull request Jan 18, 2023
docs(samples): Added comments (#425)
1bcc956 
* docs(samples): Added comments

* changed comment
yil532 mentioned this pull request Feb 1, 2023
Merged
8 tasks
dandhlee pushed a commit that referenced this pull request Feb 6, 2023
docs(samples): Added comments (#425)
84d16a2 
* docs(samples): Added comments

* changed comment
telpirion pushed a commit that referenced this pull request Mar 13, 2023
docs(samples): Added comments (#425)
2f09696 
* docs(samples): Added comments

* changed comment
dizcology pushed a commit that referenced this pull request Jun 16, 2023
chore(deps): update dependency pytest to v7.2.1 (#425)
776f88f
dizcology mentioned this pull request Jun 16, 2023
Merged
9 tasks
dizcology pushed a commit that referenced this pull request Jul 10, 2023
chore(deps): update dependency pytest to v7.2.1 (#425)
f1d9828
leahecole pushed a commit that referenced this pull request Jul 11, 2023
chore(deps): update dependency pytest to v7.2.1 (#425)
a7cadb4
dizcology pushed a commit that referenced this pull request Sep 11, 2023
chore(deps): update dependency google-cloud-videointelligence to v2.1…
f5a1fe6 
…1.2 (#425)

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
dizcology mentioned this pull request Sep 11, 2023
Merged
9 tasks
leahecole pushed a commit that referenced this pull request Sep 15, 2023
chore(deps): update dependency google-cloud-videointelligence to v2.1…
96f98f5 
…1.2 (#425)

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

waprin

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL