FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Auth samples for Endpoints. by liminw · Pull Request #431 · GoogleCloudPlatform/python-docs-samples · GitHub

/ python-docs-samples Public

Auth samples for Endpoints. - #431

Merged
theacodes merged 3 commits into
GoogleCloudPlatform:masterfrom
liminw:master
Aug 2, 2016
ConversationCommits (3)ChecksFiles changed
Merged

Auth samples for Endpoints.#431
theacodes merged 3 commits into
GoogleCloudPlatform:masterfrom
liminw:master

Conversation

liminw commented Jul 28, 2016

Copy link
Copy Markdown
Contributor

Added three samples:

  1. Use App Engine default service account client (without key file).
  2. Use non-default service account client (without key file).
  3. Use Google ID token client (without key file)

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 28, 2016
theacodes reviewed Jul 28, 2016
View reviewed changes
Comment thread appengine/flexible/endpoints/README.md Outdated

theacodes Jul 28, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Isn't with key file implied? Is there any way to do it without a key file?

liminw Jul 28, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

All the three auth samples added here are to show how to authenticate with endpoints without a key file.

theacodes commented Jul 28, 2016

Copy link
Copy Markdown
Contributor

Finished a first pass. Let me know when you're ready for another pass.

liminw force-pushed the master branch 2 times, most recently from 537e0a1 to 97e7d65 Compare July 29, 2016 21:02
Auth samples for Endpoints.
6ecc915 
Added three samples:
1. Use App Engine default service account client (without key file).
2. Use non-default service account client (without key file).
3. Use Google ID token client (without key file)
theacodes reviewed Jul 29, 2016
View reviewed changes
Comment thread appengine/flexible/endpoints/requirements.txt Outdated
six==1.10.0
pyyaml==3.11
requests==2.10.0
google-api-python-client

theacodes Jul 29, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

please pin the version, I think 1.5.1 is the latest.

theacodes commented Jul 29, 2016

Copy link
Copy Markdown
Contributor

Code looks mostly good, two things I would like to see in the README before we merge this:

  1. update appcfg.py usage to gcloud app.
  2. Make it very clear that these are App Engine standard applications.

theacodes reviewed Aug 1, 2016
View reviewed changes
Comment thread appengine/flexible/endpoints/README.md Outdated
4. Upload your application to Google App Engine by invoking the following command.

appcfg.py -A <YOUR-CLIENT-PROJECT-ID> -V v1 update .
gcloud app deploy app.yaml --project=<YOUR-CLIENT-PROJECT-ID> --promote

theacodes Aug 1, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Neither --project or --promote are needed for gcloud app

theacodes merged commit e82c5bc into GoogleCloudPlatform:master Aug 2, 2016

theacodes commented Aug 2, 2016

Copy link
Copy Markdown
Contributor

Merged. Thank you!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL