FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fixup nox by theacodes · Pull Request #462 · GoogleCloudPlatform/python-docs-samples · GitHub

/ python-docs-samples Public

Fixup nox - #462

Merged
dpebot merged 4 commits into
masterfrom
fixup-nox
Aug 18, 2016
ConversationCommits (4)ChecksFiles changed
Merged

Fixup nox#462
dpebot merged 4 commits into
masterfrom
fixup-nox

Conversation

theacodes commented Aug 17, 2016

Copy link
Copy Markdown
Contributor

This enables grpc tests on python 3 and unifies the app engine and python 2.7 test suite (woohoo).

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 17, 2016
Jon Wayne Parrott added 2 commits August 17, 2016 14:58
Remove grpc-python3 hackiness
d062c2e 
Change-Id: I6bf9a8acb9ba7d067b3095b5857094cbc322ff58
Unifiy app engine and python2.7 tests.
a25007b 
Change-Id: Ie0df6747050035b2ef5f937951d5ff955073e6d4
Don't skip flaky with session tests
0952e89 
Change-Id: I0d3bdf3d6842339d04abc4ee6ddb26b8f44be3e5
jerjou reviewed Aug 17, 2016
View reviewed changes
Comment thread bigtable/hello/main.py
row.set_cell(
column_family_id,
column_id.encode('utf-8'),
column_id,

jerjou Aug 17, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should this have some six magic for python2 compatibility?

waprin Aug 17, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think Jon is just fixing a double encode? I think in general if you want Python strings as bytes, do the encode, no six necessary.

jerjou Aug 17, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ah cool. I totally didn't look at the context ^_^;

theacodes Aug 18, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yeah fixing a double encode. No idea how this worked on py2.7 other than luck.

waprin commented Aug 17, 2016

Copy link
Copy Markdown
Contributor

hooray. code lgtm. running it locally if you want to wait for that but I'm guessing any problems there will be doc issues anyway.

jerjou reviewed Aug 17, 2016
View reviewed changes
Comment thread appengine/standard/conftest.py Outdated


def pytest_ignore_collect(path, config):
"""Skip App Engine tests in python 3 and if no SDK is available."""

jerjou Aug 17, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

"and" -> "or"

theacodes Aug 18, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done.

jerjou commented Aug 17, 2016

Copy link
Copy Markdown
Contributor

LGTM if LGTTravis

Fix lint issue and review comments
b8792d9 
Change-Id: I02a53961b6411247ef06d84dad7b533cb97d89f7

theacodes commented Aug 18, 2016

Copy link
Copy Markdown
Contributor Author

@dpebot merge when travis passes

dpebot commented Aug 18, 2016

Copy link
Copy Markdown
Collaborator

Okay! I'll merge when all statuses are green.

dpebot added the automerge Merge the pull request once unit tests and other checks pass. label Aug 18, 2016
dpebot merged commit 057b053 into master Aug 18, 2016
dpebot deleted the fixup-nox branch August 18, 2016 17:17
jerjou mentioned this pull request Sep 6, 2016
Closed
telpirion mentioned this pull request Jan 13, 2023
Merged
8 tasks
telpirion pushed a commit that referenced this pull request Jan 13, 2023
docs(samples): Update code samples for adaptation and VAD (#462)
cc2137d 
Co-authored-by: AJ Morozoff <amorozoff@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
telpirion mentioned this pull request Jan 18, 2023
Closed
8 tasks
telpirion pushed a commit that referenced this pull request Jan 18, 2023
chore(python): Noxfile recognizes that tests can live in a folder (#462)
b72c5ec 
Source-Link: googleapis/synthtool@4760d8d
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f0e4b51deef56bed74d3e2359c583fc104a8d6367da3984fc5c66938db738828

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
yil532 mentioned this pull request Feb 1, 2023
Merged
8 tasks
dandhlee pushed a commit that referenced this pull request Feb 6, 2023
chore(python): Noxfile recognizes that tests can live in a folder (#462)
bae54d2 
Source-Link: googleapis/synthtool@4760d8d
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f0e4b51deef56bed74d3e2359c583fc104a8d6367da3984fc5c66938db738828

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sita04 mentioned this pull request Feb 7, 2023
Merged
8 tasks
Sita04 pushed a commit that referenced this pull request Feb 7, 2023
chore(main): release 3.10.0 (#462)
3a4354d 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
dandhlee pushed a commit that referenced this pull request Feb 9, 2023
docs(samples): Update code samples for adaptation and VAD (#462)
c0602c1 
Co-authored-by: AJ Morozoff <amorozoff@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
telpirion pushed a commit that referenced this pull request Mar 13, 2023
chore(python): Noxfile recognizes that tests can live in a folder (#462)
0b756fc 
Source-Link: googleapis/synthtool@4760d8d
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f0e4b51deef56bed74d3e2359c583fc104a8d6367da3984fc5c66938db738828

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
telpirion pushed a commit that referenced this pull request Mar 13, 2023
docs(samples): Update code samples for adaptation and VAD (#462)
3ee5593 
Co-authored-by: AJ Morozoff <amorozoff@google.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

jerjou

waprin

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL