FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add Scipy example by waprin · Pull Request #474 · GoogleCloudPlatform/python-docs-samples · GitHub

/ python-docs-samples Public

Add Scipy example - #474

Merged
waprin merged 5 commits into
masterfrom
scipy2
Aug 24, 2016
ConversationCommits (5)ChecksFiles changed
Merged

Add Scipy example#474
waprin merged 5 commits into
masterfrom
scipy2

Conversation

waprin commented Aug 23, 2016

Copy link
Copy Markdown
Contributor

I tried to keep this pretty simple just to demonstrate it works on Flex.

Could use GCS to make it a little less clumsy but leaned towards simplicity.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 23, 2016

cloud-dpe-jenkins commented Aug 23, 2016

Copy link
Copy Markdown

Hmm

cloud-dpe-jenkins commented Aug 23, 2016

Copy link
Copy Markdown

I also love scipy!

waprin commented Aug 23, 2016

Copy link
Copy Markdown
Contributor Author

test3

cloud-dpe-jenkins commented Aug 24, 2016

Copy link
Copy Markdown

Starting a new build on Jenkins!

cloud-dpe-jenkins commented Aug 24, 2016

Copy link
Copy Markdown

test4

cloud-dpe-jenkins commented Aug 24, 2016

Copy link
Copy Markdown

Build finished.

theacodes reviewed Aug 24, 2016
View reviewed changes
Comment thread .gitignore Outdated
junit.xml
credentials.dat
.nox
appengine/flexible/scipy/assets/resized_google_logo.jpg No newline at end of file

theacodes Aug 24, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just add this to the .gitignore in /appengine/flexible/scipy.

waprin Aug 24, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

done

waprin merged commit c8cfbe2 into master Aug 24, 2016
jerjou reviewed Aug 29, 2016
View reviewed changes
Comment thread appengine/flexible/scipy/main.py
app_path = os.path.dirname(os.path.realpath(__file__))
image_path = os.path.join(app_path, 'assets/google_logo.jpg')
img = scipy.misc.imread(image_path)
img_tinted = scipy.misc.imresize(img, (300, 300))

jerjou Aug 29, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

perhaps img_resized instead? Also, update the comment in line 34

theacodes Aug 29, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It's been merged and Bill's at burning man, man. Send a PR if you feel strongly.

jerjou Aug 29, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just catching up on email 😅

theacodes deleted the scipy2 branch August 29, 2016 18:09
jerjou reviewed Aug 29, 2016
View reviewed changes
Comment thread appengine/flexible/scipy/main.py
img = scipy.misc.imread(image_path)
img_tinted = scipy.misc.imresize(img, (300, 300))
output_image_path = os.path.join(
app_path, 'assets/resized_google_logo.jpg')

jerjou Aug 29, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Probably unnecessary to have the resized file checked in, since that's what you're generating..

Sita04 mentioned this pull request Feb 7, 2023
Merged
8 tasks
Sita04 pushed a commit that referenced this pull request Feb 7, 2023
feat: Add support for python 3.11 (#474)
03d2ad4 
* feat: Add support for python 3.11

chore: Update gapic-generator-python to v1.8.0
PiperOrigin-RevId: 500768693

Source-Link: googleapis/googleapis@190b612

Source-Link: https://github.com/googleapis/googleapis-gen/commit/7bf29a414b9ecac3170f0b65bdc2a95705c0ef1a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

theacodes

jerjou

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL