FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: Update noxfile_config.py header year by davidcavazos · Pull Request #6558 · GoogleCloudPlatform/python-docs-samples · GitHub

/ python-docs-samples Public

chore: Update noxfile_config.py header year - #6558

Merged
leahecole merged 5 commits into
masterfrom
update-noxfile-config-year
Aug 31, 2021
ConversationCommits (5)ChecksFiles changed
Merged

chore: Update noxfile_config.py header year#6558
leahecole merged 5 commits into
masterfrom
update-noxfile-config-year

Conversation

davidcavazos commented Aug 12, 2021

Copy link
Copy Markdown

Description

Copying noxfile_config.py with the current year so we don't have to manually change it each time we copy it :)

Checklist

Update noxfile_config.py header year
f7d14a9 
Copying noxfile_config.py with the current year so we don't have to manually change it each time we copy it :)
davidcavazos requested a review from a team as a code owner August 12, 2021 23:27
product-auto-label Bot added the samples Issues that are directly related to samples. label Aug 12, 2021
google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 12, 2021

dandhlee commented Aug 12, 2021

Copy link
Copy Markdown
Collaborator

I was strictly told by OSPO guidelines to not touch the license header after it gets added.

@JustinBeckwith would you happen to know if we're allowed to change the license header for template files like these?

JustinBeckwith commented Aug 13, 2021

Copy link
Copy Markdown
Contributor

@dandhlee let's talk this one over on monday in chat

dandhlee commented Aug 13, 2021

Copy link
Copy Markdown
Collaborator

Sounds good!

leahecole added the status: blocked Resolving the issue is dependent on other work. label Aug 13, 2021

leahecole commented Aug 13, 2021

Copy link
Copy Markdown
Collaborator

Marking as blocked until after Justin and Dan get to chat

parthea changed the title Update noxfile_config.py header year chore: Update noxfile_config.py header year Aug 14, 2021

leahecole commented Aug 16, 2021

Copy link
Copy Markdown
Collaborator

@dandhlee any updates?

dandhlee commented Aug 16, 2021

Copy link
Copy Markdown
Collaborator

@leahecole going to have our chat soon!

dandhlee assigned dandhlee and unassigned leahecole Aug 16, 2021
dandhlee removed the status: blocked Resolving the issue is dependent on other work. label Aug 18, 2021
dandhlee approved these changes Aug 18, 2021
View reviewed changes

dandhlee left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Template files are fine :) Got confirmation by the lawyer cat 🐈

dandhlee requested a review from a team August 27, 2021 19:00
leahecole merged commit 6d7d39d into master Aug 31, 2021
leahecole deleted the update-noxfile-config-year branch August 31, 2021 19:01
meredithslota mentioned this pull request Mar 10, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

leahecole leahecole approved these changes
dandhlee dandhlee approved these changes

Assignees

dandhlee

Labels

cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL