FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Updates to Google ID token service-to-service auth sample by liminw · Pull Request #674 · GoogleCloudPlatform/python-docs-samples · GitHub

/ python-docs-samples Public

Updates to Google ID token service-to-service auth sample - #674

Merged
dpebot merged 3 commits into
GoogleCloudPlatform:masterfrom
liminw:mmm
Nov 21, 2016
ConversationCommits (3)ChecksFiles changed
Merged

Updates to Google ID token service-to-service auth sample#674
dpebot merged 3 commits into
GoogleCloudPlatform:masterfrom
liminw:mmm

Conversation

liminw commented Nov 18, 2016

Copy link
Copy Markdown
Contributor

No description provided.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 18, 2016
theacodes reviewed Nov 21, 2016
View reviewed changes
Comment thread appengine/flexible/endpoints/clients/service_to_service_google_id_token/main.py
import webapp2

DEFAUTL_SERVICE_ACCOUNT = "YOUR-CLIENT-PROJECT-ID@appspot.gserviceaccount.com"
SERVICE_ACCOUNT_EMAIL = "YOUR-CLIENT-PROJECT-ID@appspot.gserviceaccount.com"

theacodes Nov 21, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think you can grab this from app_identity: app_identity. get_service_account_name()

liminw Nov 21, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Hi Jon, thanks for the review. I prefer to use a constant SERVICE_ACCOUNT_EMAIL here. This way, the code snippet for filling out payload would look the same for both default service account and non-default service account.

theacodes Nov 21, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sounds good.

theacodes commented Nov 21, 2016

Copy link
Copy Markdown
Contributor

@dpebot can you merge when travis is green?

dpebot commented Nov 21, 2016

Copy link
Copy Markdown
Collaborator

Okay! I'll merge when all statuses are green.

dpebot added the automerge Merge the pull request once unit tests and other checks pass. label Nov 21, 2016
dpebot merged commit e43f218 into GoogleCloudPlatform:master Nov 21, 2016
chalmerlowe pushed a commit that referenced this pull request Apr 7, 2026
samples: storage_download_byte_range (#674)
d1863ba 
* samples: storage_download_byte_range

* added spacing

* updated readme

* fixed test
chalmerlowe mentioned this pull request Apr 7, 2026
Merged
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
theacodes theacodes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL