FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

BigQuery samples using query parameters. by tswast · Pull Request #699 · GoogleCloudPlatform/python-docs-samples · GitHub

/ python-docs-samples Public

BigQuery samples using query parameters. - #699

Merged
theacodes merged 1 commit into
masterfrom
tswast-bq
Dec 6, 2016
ConversationCommits (1)ChecksFiles changed
Merged

BigQuery samples using query parameters.#699
theacodes merged 1 commit into
masterfrom
tswast-bq

Conversation

tswast commented Dec 5, 2016

Copy link
Copy Markdown
Contributor

This query syntax is supported in the not-yet-released version of google-cloud-python in googleapis/google-cloud-python#2776.

I've added the do not merge label, since we should wait for the next google-cloud-python release, but the sample should be ready to review.

tswast added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 5, 2016
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 5, 2016
theacodes suggested changes Dec 5, 2016
View reviewed changes
Comment thread bigquery/cloud-client/async_query_params.py Outdated

theacodes Dec 5, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

add with parameters?

Comment thread bigquery/cloud-client/async_query_params.py Outdated

theacodes Dec 5, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you do two separate sample functions instead of one?

tswast Dec 5, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done.

Yes, splitting into separate functions should make it a little easier to talk about in the docs I write for this, too.

theacodes suggested changes Dec 5, 2016
View reviewed changes

theacodes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Do you need both sync and async? We already have a comprehensive sample on async querying, is it worthwhile to duplicate here or would a comment mentioning that you could also do this async work?

Comment thread bigquery/cloud-client/async_query_params.py Outdated
print_results(query_job.results())


def main(use_named_params=False, corpus='romeoandjuliet', min_word_count=100):

theacodes Dec 5, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No main function, please.

theacodes commented Dec 6, 2016

Copy link
Copy Markdown
Contributor

@tswast a new bigquery version has been released.

tswast changed the title [DO NOT MERGE] BigQuery samples using query parameters. BigQuery samples using query parameters. Dec 6, 2016
tswast removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 6, 2016

tswast commented Dec 6, 2016

Copy link
Copy Markdown
Contributor Author

Thanks. I've updated the package and deleted the async sample. You're right. They are so similar, it's probably not worth including both.

theacodes reviewed Dec 6, 2016
View reviewed changes
Comment thread bigquery/cloud-client/sync_query_params_test.py Outdated

theacodes Dec 6, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Import modules, not names.

tswast Dec 6, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done.

BigQuery parameterized query sample
beb4513 
Available in latest version of google-cloud-bigquery (0.22.0), so
upgrades the requirement, too.
theacodes merged commit 704c564 into master Dec 6, 2016
theacodes deleted the tswast-bq branch December 6, 2016 23:01
plamut pushed a commit to plamut/python-bigquery that referenced this pull request Jun 25, 2020
BigQuery parameterized query sample [(googleapis#699)](GoogleCloudPla…
961f326 
…tform/python-docs-samples#699)

Available in latest version of google-cloud-bigquery (0.22.0), so
upgrades the requirement, too.
plamut pushed a commit to plamut/python-bigquery that referenced this pull request Jul 22, 2020
BigQuery parameterized query sample [(googleapis#699)](GoogleCloudPla…
9c63f3f 
…tform/python-docs-samples#699)

Available in latest version of google-cloud-bigquery (0.22.0), so
upgrades the requirement, too.
shollyman pushed a commit to googleapis/python-bigquery that referenced this pull request Jul 22, 2020
BigQuery parameterized query sample [(#699)](GoogleCloudPlatform/pyth…
4f8c66f 
…on-docs-samples#699)

Available in latest version of google-cloud-bigquery (0.22.0), so
upgrades the requirement, too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
theacodes theacodes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

theacodes

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL