FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Hackathon/Codelab vision sample by ryanmats · Pull Request #788 · GoogleCloudPlatform/python-docs-samples · GitHub

/ python-docs-samples Public

Hackathon/Codelab vision sample - #788

Merged
theacodes merged 18 commits into
masterfrom
hackathon-vision-sample
Feb 17, 2017
ConversationCommits (18)ChecksFiles changed
Merged

Hackathon/Codelab vision sample#788
theacodes merged 18 commits into
masterfrom
hackathon-vision-sample

Conversation

ryanmats commented Feb 8, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

A work in progress for EDU hackathons / Codelab.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 8, 2017

ryanmats commented Feb 14, 2017

Copy link
Copy Markdown
Contributor Author

Still TODO: use Jinja2 for HTML output, README instructions

ryanmats requested a review from theacodes February 14, 2017 02:38
ryanmats changed the title Hackathon vision sample Hackathon/Codelab vision sample Feb 14, 2017
theacodes reviewed Feb 15, 2017
View reviewed changes

theacodes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

No tests?

Comment thread appengine/flexible/vision/main.py Outdated
@@ -0,0 +1,127 @@
# Copyright 2015 Google Inc. All Rights Reserved.

theacodes Feb 15, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

2017?

Comment thread appengine/flexible/vision/main.py Outdated
from google.cloud import vision


CLOUD_STORAGE_BUCKET = '<your-storage-bucket>'

theacodes Feb 15, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Use os.environ and env_variables in app.yaml? (or do you have a good reason for this?)

ryanmats commented Feb 16, 2017

Copy link
Copy Markdown
Contributor Author

will add test(s) soon

theacodes commented Feb 16, 2017

Copy link
Copy Markdown
Contributor

@ryanmats this looks good, I'd just prefer we put it under /codelabs/flex_and_vision or similar.

theacodes commented Feb 16, 2017

Copy link
Copy Markdown
Contributor

Please create a bug for yourself to add tests.

theacodes merged commit 26eb8ce into master Feb 17, 2017
theacodes deleted the hackathon-vision-sample branch February 17, 2017 21:56
chalmerlowe pushed a commit that referenced this pull request Apr 7, 2026
chore(deps): update dependency google-cloud-pubsub to v2.12.1 (#788)
62fc512 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
chalmerlowe mentioned this pull request Apr 7, 2026
Merged
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
theacodes theacodes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL