FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix creating new image if file is unchanged. by garygreen · Pull Request #116 · Gregwar/Image · GitHub

/ Image Public

Fix creating new image if file is unchanged. - #116

Open
garygreen wants to merge 1 commit into
Gregwar:masterfrom
garygreen:fix-image-unchanged
ConversationCommits (1)ChecksFiles changed
Open

Fix creating new image if file is unchanged.#116
garygreen wants to merge 1 commit into
Gregwar:masterfrom
garygreen:fix-image-unchanged

Conversation

garygreen commented May 18, 2016

Copy link
Copy Markdown
Contributor

Fixes #115.

garygreen force-pushed the fix-image-unchanged branch 3 times, most recently from 7f604d5 to f23f1a8 Compare May 18, 2016 13:19
garygreen force-pushed the fix-image-unchanged branch from f23f1a8 to b5bd0d9 Compare May 18, 2016 13:20

garygreen commented Jun 10, 2016

Copy link
Copy Markdown
Contributor Author

@Gregwar any news on this?

hirbod commented Jun 12, 2016

Copy link
Copy Markdown

👍 really important fix

Gregwar commented Jun 12, 2016

Copy link
Copy Markdown
Owner

Why the quality have to be 100 for this?

garygreen commented Jun 13, 2016 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Because it essentially means your not changing the image. If you wanted 100% of the original quality image, that means you just want to copy it. If it's 99% that means you want to change the image to a 1% lower quality version. That's how I see it anyway...

garygreen commented Jun 17, 2016

Copy link
Copy Markdown
Contributor Author

Any news @Gregwar ?

garygreen commented Jun 28, 2016

Copy link
Copy Markdown
Contributor Author

@Gregwar @soullivaneuh any news on this? At this rate I'll have to maintain a separate fork as this package seems quite slow on PRs at the moment.... 😢

garygreen commented Jul 19, 2016

Copy link
Copy Markdown
Contributor Author

@Gregwar Bump again, any news buddy? 😄

Gregwar commented Jul 19, 2016

Copy link
Copy Markdown
Owner

Hello
Sorry for the delay
Shouldn't we test if the target type is also unchanged?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL