Update services.py - #548
Open
oneashkan wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
### Summary This pull request improves the `model_update` function by adding proper handling for Django `ValidationError`. It now converts it into DRF's `ValidationError` to ensure consistent API responses (HTTP 400 instead of 500). ### Changes - Added `try/except` block around `instance.full_clean()` and `instance.save()`. - Converted `django.core.exceptions.ValidationError` → `rest_framework.exceptions.ValidationError`. - Ensured clean, consistent error handling across all model update operations. ### Why Previously, unhandled validation errors resulted in server errors (500). This update ensures that all validation issues are returned properly as JSON API responses. ### Testing - Manually tested with invalid model fields. - Confirmed correct 400 responses in API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request improves the model_update function by adding proper handling for Django ValidationError. It now converts it into DRF's ValidationError to ensure consistent API responses (HTTP 400 instead of 500).
Changes
Why
Previously, unhandled validation errors resulted in server errors (500). This update ensures that all validation issues are returned properly as JSON API responses.
Testing