Add EmbedUntrackedSources - #570
Merged
oformaniuk merged 3 commits intoApr 1, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
lahma
force-pushed
the
license-expression
branch
from
4aa7934 to
ef181f6
Compare
February 16, 2024 08:17
Copy link
Copy Markdown
Contributor
Author
|
Ah, great minds think a like I guess 😄 I've updated the PR title and contents to only contain EmbedUntrackedSources set to true |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Sorry, something went wrong.
oformaniuk
enabled auto-merge
April 1, 2024 02:18
Copy link
Copy Markdown
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would also suggest changing to use newer GH Actions images for building so that other warnings would go away (old SDK in use). Maybe another modernization step could be removing old unsupported full framework targets and only support oldest supported net462. Adding net6.0 target would allow one target without dependency on Microsoft.Csharp.