FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

code-server 4.6.1 by jsjoeio · Pull Request #109430 · Homebrew/homebrew-core · GitHub

  1. Homebrew
  2. homebrew-core

Repository navigation

code-server 4.6.1 - #109430

Closed
jsjoeio wants to merge 8 commits into
Homebrew:masterfrom
jsjoeio:bump-code-server-4.6.1
ConversationCommits (8)ChecksFiles changed
Closed

code-server 4.6.1#109430
jsjoeio wants to merge 8 commits into
Homebrew:masterfrom
jsjoeio:bump-code-server-4.6.1

Conversation

jsjoeio commented Sep 1, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Created with brew bump-formula-pr in favor of #109321

jsjoeio marked this pull request as draft September 1, 2022 21:38
BrewTestBot added bump-formula-pr PR was created using `brew bump-formula-pr` no Linux bottle Formula has no Linux bottle nodejs Node or npm use is a significant feature of the PR or issue labels Sep 1, 2022
jsjoeio marked this pull request as ready for review September 1, 2022 21:46

jsjoeio commented Sep 2, 2022

Copy link
Copy Markdown
Contributor Author 
  Error: An exception occurred within a child process:
    NameError: uninitialized constant Language::Node

Hmm... gotta figure this out

carlocab reviewed Sep 2, 2022
View reviewed changes
Comment thread Formula/code-server.rb
system "npm", "install", *Language::Node.std_npm_install_args(libexec), "--unsafe-perm"
# @parcel/watcher bundles all binaries for other platforms & architectures
# This deletes the non-matching architecture otherwise brew audit will complain.
prebuilds = buildpath/"lib/vscode/node_modules/@parcel/watcher/prebuilds"

carlocab Sep 2, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Try removing the two rmtrees below, including this line.

jsjoeio Sep 2, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you! I'll try that now.

jsjoeio commented Sep 2, 2022

Copy link
Copy Markdown
Contributor Author

Really not sure on this one. The modules should be there but they're not. Going to see if I can reproduce locally and debug.

jsjoeio commented Sep 2, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Roughly speaking, this is what should be happening:

  1. code-server is installed from npm globally
  2. post installing it should run the postinstall script
  3. in the production release, we run this: https://github.com/coder/code-server/blob/90f603549adbcbb608041fda2138265523ff0353/ci/build/build-release.sh#L62
  4. something is going wrong with the postinstall but i can't tell looking at the homebrew CI logs so I'm a bit stumped

jsjoeio commented Sep 2, 2022

Copy link
Copy Markdown
Contributor Author

Looks like we need a change in code-server to fix this. Once we do that, I'll update this PR. Relevant changes: coder/code-server#5533

jsjoeio marked this pull request as draft September 2, 2022 21:09
jsjoeio mentioned this pull request Sep 2, 2022
Closed
4 tasks done

github-actions Bot commented Sep 5, 2022

Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

github-actions Bot added the stale No recent activity label Sep 5, 2022
github-actions Bot closed this Sep 6, 2022
jsjoeio deleted the bump-code-server-4.6.1 branch September 6, 2022 16:24
github-actions Bot added the outdated PR was locked due to age label Oct 7, 2022
github-actions Bot locked as resolved and limited conversation to collaborators Oct 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

carlocab carlocab left review comments

Assignees

No one assigned

Labels

bump-formula-pr PR was created using `brew bump-formula-pr` no Linux bottle Formula has no Linux bottle nodejs Node or npm use is a significant feature of the PR or issue outdated PR was locked due to age stale No recent activity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL