[QoL] Makefile addition. Makes both usage and dev more friendly. - #9
Open
peekknuf wants to merge 1 commit into
Open
[QoL] Makefile addition. Makes both usage and dev more friendly.#9peekknuf wants to merge 1 commit into
peekknuf wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces several make targets (e.g., make up, make down, make logs) to simplify common Docker Compose commands and improve developer experience, addressing the repetitive nature of typing docker compose ....
For consistency sake might want to add make run and make install among some other things, but at this point it's purely stylistic.
Container specific logs have also been quite helpful.
While reviewing container logs using the new make logs-n8n target, an interesting observation was made: even during successful chat pipeline executions, the n8n container logs frequently show errors like:
NOTE: this does not affect the core functionality of the chat pipeline but is noted here for awareness.
Might require further investigation, but not sure if it's issue worthy as it's a silent error and in no way a showstopper.