Preserve the setting of a variable when calling eager macro function. - #1070
Merged
hs-lsong merged 2 commits intoMay 8, 2023
Merged
hs-lsong merged 2 commits into
hs-lsong merged 2 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the EagerCallTag, we need to use the enterNonStackingScope instead of enterScope as the variables are in the same scope. They would have been removed if using a stacked scope. E.g.,
org.junit.ComparisonFailure: Expected :"{% set bar={} %}{% macro foo(bar, foobar, other) %} {% do bar.update({'a': 'b'}) %} {{ foobar }} {{ bar }} and {{ other }}{% endmacro %}{% call foo(bar, foobar, deferred) %} {% endcall %}{{ bar }}" Actual :"{% macro foo(bar, foobar, other) %} {% do bar.update({'a': 'b'} ) %} {{ foobar }} {{ bar }} and {{ other }}{% endmacro %}{% call foo(bar, null, deferred) %} {% endcall %}{{ bar }}"