Unwrap JsonMappingException if cause is LengthLimitingJsonProcessingException - #1082
Merged
jasmith-hs merged 2 commits intoJun 16, 2023
Merged
Unwrap JsonMappingException if cause is LengthLimitingJsonProcessingException#1082jasmith-hs merged 2 commits into
jasmith-hs merged 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
boulter
approved these changes
Jun 15, 2023
boulter
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
thank you
Sorry, something went wrong.
jasmith-hs
commented
Jun 16, 2023
Comment on lines
+47
to
+49
| if (JinjavaInterpreter.isOutputTooLarge(output)) { | ||
| return wrapEagerInterpret(tagNode, interpreter, null); | ||
| } |
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
We only want to do the deferred execution eager interpret if we fully succeeded, but the output is too large. If we encountered an uncaught OutputTooBigException while running innerInterpret, we haven't handled that, and the context won't be in a proper state. (It likely would come from attempting to reconstruct a value, but its string representation is too large.)
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow up to #1051, since these exceptions are now wrapped in JsonMappingException, we can unwrap them to see if they are caused by LengthLimitingJsonProcessingException so that we'll convert it to an OutputTooBigException