FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Python3.9 compatible by pancak3 · Pull Request #85 · HuobiRDCenter/huobi_Python · GitHub

Python3.9 compatible - #85

Open
pancak3 wants to merge 2 commits into
HuobiRDCenter:masterfrom
pancak3:py39
Open

Python3.9 compatible#85
pancak3 wants to merge 2 commits into
HuobiRDCenter:masterfrom
pancak3:py39

Conversation

pancak3 commented Feb 4, 2021

Copy link
Copy Markdown
Contributor

json.loads removed arg encoding since python 3.9, see 'https://docs.python.org/3.9/library/json.html#json.loads'

Qumeric commented Apr 13, 2021
edited
Loading

Copy link
Copy Markdown

I think

is_below_py39 = False
if sys.version_info.major < 3 and sys.version_info.minor < 9:
    is_below_py39 = True

Should be moved inside json_loads. Maybe import sys too.

Also, maybe encoding can be dropped even for Python 3.7 and 3.8?

pancak3 commented Apr 14, 2021

Copy link
Copy Markdown
Contributor Author

I think

is_below_py39 = False
if sys.version_info.major < 3 and sys.version_info.minor < 9:
    is_below_py39 = True

Should be moved inside json_loads. Maybe import sys too.

Also, maybe encoding can be dropped even for Python 3.7 and 3.8?

I think

is_below_py39 = False
if sys.version_info.major < 3 and sys.version_info.minor < 9:
    is_below_py39 = True

Should be moved inside json_loads. Maybe import sys too.

Also, maybe encoding can be dropped even for Python 3.7 and 3.8?

Excellent advice! I am going to change it. Thanks!

Copy link
Copy Markdown

I have the same problem. @pancak3, thanks for this fix! Сould you please merge this PR?

pancak3 commented May 31, 2022

Copy link
Copy Markdown
Contributor Author

I have the same problem. @pancak3, thanks for this fix! Сould you please merge this PR?

Haha this is really an old PR! I would like to help, but only authorized users are allowed to merge. Maybe you can try rebase in your local environment.

Copy link
Copy Markdown

I have the same problem. @pancak3, thanks for this fix! Сould you please merge this PR?

Haha this is really an old PR! I would like to help, but only authorized users are allowed to merge. Maybe you can try rebase in your local environment.

Yes, I merged the PR in my own repository. But I do not give up hope that an authorized user will merge this PR. I just didn't find a better user to mention in this PR 🙂

pancak3 commented May 31, 2022

Copy link
Copy Markdown
Contributor Author

They did not maintain this for a long time. This branch may be merged decades later :D

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL