Fix the wrong definition of avnorm in applyExp - #315
Open
mingruyang wants to merge 3 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Hi Mingru, Sorry for the slow response. Have you seen that this change makes a difference in calculations you are doing (not doubting that it is the correct thing to do, just curious)? Cheers, |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Hi Matt,
I only tested it with the sample code in the TDVP repo. Actually I didn’t see any difference in the results but it runs slightly slower.
I think it doesn’t matter in the current setting but might affect the time step adjusting.
Best,
Mingru
… On Jan 16, 2020, at 11:44 AM, mtfishman ***@***.***> wrote:
Hi Mingru,
Sorry for the slow response. Have you seen that this change makes a difference in calculations you are doing (not doubting that it is the correct thing to do, just curious)?
Cheers,
Matt
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#315?email_source=notifications&email_token=AEHX2T5VNJ76DSV2P7CT5T3Q6C2JTA5CNFSM4KDLP7LKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJFJNFY#issuecomment-575313559>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AEHX2T7TBUOGSAM6IWF43E3Q6C2JTANCNFSM4KDLP7LA>.
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to page 17 of this paper, avnorm which is used for error estimate should be Av_{m+1} instead of Av_m.