Support additional rain configuration - #2
Ian-bug merged 1 commit into
Conversation
Sorry, something went wrong.
WalkthroughFade configuration is relocated from static DisplayConstants constants (FADE_START_Y, FADE_RANGE) into KeyViewerSettings as three new user-configurable fields: fade_position_y, fade_length_y, and fade_trigger. Validation, persistence, overlay rendering, and UI controls are all updated accordingly. ChangesConfigurable Fade Settings
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem🚥 Pre-merge checks | ✅ 5 ✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches 🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. ❤️ ShareComment @coderabbitai help to get the list of available commands and usage tips. |
Sorry, something went wrong.
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)core/ui/components.py (1)341-351: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win
Block fade-trigger combo signals during config sync to avoid re-entrant saves.
Line 364 updates combo_kv_fade_trig, but it isn’t included in signals_blocked(...) (Lines 341-351). That can emit currentTextChanged, call on_change(), and trigger an unnecessary nested save() cycle.
Suggested fixwith signals_blocked( self.chk_kv_enabled, self.spin_kv_height, self.combo_kv_pos, self.spin_kv_off_x, self.spin_kv_off_y, self.spin_kv_opacity, self.chk_kv_counts, self.spin_kv_fade_pos, - self.spin_kv_fade_len + self.spin_kv_fade_len, + self.combo_kv_fade_trig ):Also applies to: 364-364
🤖 Prompt for AI AgentsVerify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@core/ui/components.py` around lines 341 - 351, The signals_blocked() context manager (lines 341-351) does not include self.combo_kv_fade_trig in its list of widgets, but this widget is updated at line 364. When the widget is updated outside the signal blocking context, it emits currentTextChanged, which calls on_change() and triggers an unnecessary nested save() cycle. Add self.combo_kv_fade_trig to the list of widgets passed to the signals_blocked() call to prevent signal emission during configuration synchronization.
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. Inline comments: In `@core/configuration.py`: - Around line 154-157: The clamping operation for fade_length_y uses max(0, ...) which allows the value to drop below the minimum bound of 10 that was validated on line 154, potentially causing division by zero in _draw_active_bars(). Fix this by changing the max(0, ...) call to max(10, ...) to enforce the consistent minimum bound of 10 that matches the validation check. --- Outside diff comments: In `@core/ui/components.py`: - Around line 341-351: The signals_blocked() context manager (lines 341-351) does not include self.combo_kv_fade_trig in its list of widgets, but this widget is updated at line 364. When the widget is updated outside the signal blocking context, it emits currentTextChanged, which calls on_change() and triggers an unnecessary nested save() cycle. Add self.combo_kv_fade_trig to the list of widgets passed to the signals_blocked() call to prevent signal emission during configuration synchronization.
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info ⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 7863bbf6-690c-4393-9cbd-598f36b20afc
📥 CommitsReviewing files that changed from the base of the PR and between 94de54b and f0433b1.
📒 Files selected for processing (5)- core/configuration.py
- core/gui.py
- core/overlay.py
- core/settings_manager.py
- core/ui/components.py
Sorry, something went wrong.
| if not (10 <= self.fade_length_y <= max_screen_y): | ||
| logger.warning(f"Fade length {self.fade_length_y} out of range [10, {max_screen_y}], clamping") | ||
| self.fade_length_y = max(0, min(max_screen_y, self.fade_length_y)) | ||
| valid = False |
There was a problem hiding this comment.
⚠️ Potential issue | 🔴 Critical | ⚡ Quick win
Clamp for fade_length_y violates its own minimum bound and can crash rendering.
Line 154 enforces a minimum of 10, but Line 156 clamps with max(0, ...), which allows 0. That can propagate to _draw_active_bars() and trigger division by zero at dist_into_fade / fade_length_y.
Suggested fix- if not (10 <= self.fade_length_y <= max_screen_y):
+ if not (10 <= self.fade_length_y <= max_screen_y):
logger.warning(f"Fade length {self.fade_length_y} out of range [10, {max_screen_y}], clamping")
- self.fade_length_y = max(0, min(max_screen_y, self.fade_length_y))
+ self.fade_length_y = max(10, min(max_screen_y, self.fade_length_y))
valid = False‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| if not (10 <= self.fade_length_y <= max_screen_y): | |
| logger.warning(f"Fade length {self.fade_length_y} out of range [10, {max_screen_y}], clamping") | |
| self.fade_length_y = max(0, min(max_screen_y, self.fade_length_y)) | |
| valid = False | |
| if not (10 <= self.fade_length_y <= max_screen_y): | |
| logger.warning(f"Fade length {self.fade_length_y} out of range [10, {max_screen_y}], clamping") | |
| self.fade_length_y = max(10, min(max_screen_y, self.fade_length_y)) | |
| valid = False |
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@core/configuration.py` around lines 154 - 157, The clamping operation for fade_length_y uses max(0, ...) which allows the value to drop below the minimum bound of 10 that was validated on line 154, potentially causing division by zero in _draw_active_bars(). Fix this by changing the max(0, ...) call to max(10, ...) to enforce the consistent minimum bound of 10 that matches the validation check.
Sorry, something went wrong.
|
ill check when I have time |
Sorry, something went wrong.
As a response to #1
The PR doesn't contain edits to the README.md and any other documentation that might require it.
Summary by CodeRabbit
Release Notes