do not assert both subject-id and pairwise-id - #987
Open
johanlundberg wants to merge 3 commits into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
default to pairwise-id if both are requested and available
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
do not assert both subject-id and pairwise-id
default to pairwise-id if both are requested and available
The feature or problem addressed by this PR
When a SP requests subject-id any there pysaml2 will add both subject-id and pairwise-id to the list of required attributes which means that both will be released if they are available.
What your changes do and why you chose this solution
This PR will check if both subject-id and pairwise-id is in available attributes and default to only release pairwise-id if both are. This check only runs if the urn:oasis:names:tc:SAML:profiles:subject-id:req is set to any.
Checklist