This repository was archived by the owner on Feb 19, 2019. It is now read-only.
Make a CDK zip instead of having a CDK repo - #17
Merged
LeafHacker merged 1 commit intoAug 14, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
We don't really need a separate repo for the CDK, when really we want to build a CDK zip whenever we update ClientAPI. This commit adds a build task to do just that. It takes generic files from ClientAPI (license, gradle), CDK specific files and the example source code and archives them as a zip file in build/distributions. This means we kan keep all the CDK specific files here (in a cdk dir) and stop maintaining yet another repo.
ZeroMemes
approved these changes
Aug 14, 2017
ZeroMemes
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looks good™
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by the way Forge builds its MDK, we should do the same with out CDK.
We don't really need a separate repo for the CDK, when really we want to build a CDK zip whenever we update ClientAPI.
This commit adds a build task to do just that. It takes generic files from ClientAPI (license, gradle), CDK specific files and the example source code and archives them as a zip file in build/distributions.
This means we kan keep all the CDK specific files here (in a cdk dir) and stop maintaining yet another repo.
This also means that the example code is no longer needed in multiple locations and we will be able to bin the complicated submodule setup. I've not done that here to keep the commit small/single purpose and because the example repo isn't up to date with @ZeroMemes's local copy.