Changes needed for autovalidation (#2225) - #167
Open
ljahn wants to merge 1 commit into
Open
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
NeroBurner
reviewed
Jan 13, 2025
Comment thread
sim/components/firmwarevalidator/FirmwareValidator.cpp
Outdated
| // NVIC_SystemReset(); | ||
| } | ||
|
|
||
| void FirmwareValidator::AutoValidate() {} No newline at end of file |
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
I Mike newlines at the enf of a file to prevent the red stop signs in the diff viewer of github
Suggested change
| void FirmwareValidator::AutoValidate() {} | |
| void FirmwareValidator::AutoValidate() {} | |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Done
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some fixes for the simulator if InfiniTimeOrg/InfiniTime#2225 gets merged in InfiniTime