build(cmake): detect and use SDL2 include path correctly - #193
Merged
NeroBurner merged 1 commit intoMar 27, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Not all distros/packages place the SDL2 installation into a directory named SDL2. Just to name a prominent example: Homebrew. cmake's find_package will correctly identify SDL2 and provide the required include/lib paths.
NeroBurner
approved these changes
Mar 27, 2026
NeroBurner
left a comment
Copy link
Copy Markdown
Collaborator
There was a problem hiding this comment.
works locally for me as well (Arch by the way ;) )
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not all distros/packages place the SDL2 installation into a directory named SDL2. Just to name a prominent example: Homebrew.
cmake's find_package will correctly identify SDL2 and provide the required include/lib paths.