| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
@yehoshuapw could you review my changes And maybe also the sister PR in InfiniSim InfiniTimeOrg/InfiniSim#29 |
Sorry, something went wrong.
There was a problem hiding this comment.
Looks good as far as I can tell.
Sorry, something went wrong.
There was a problem hiding this comment.
overall, it looks excellent (and the CMake much better) - thanks.
I added a few comment for consistency.
Sorry, something went wrong.
There was a problem hiding this comment.
I noticed that this always re-generates the font, whereas before it didn't if it wasn't necessary.
Sorry, something went wrong.
|
valid concern, yes I need to fix that! Thanks for pointing that out |
Sorry, something went wrong.
There was a problem hiding this comment.
That looks really good to me! I like the new static library that contains all the fonts! 👍
We'll be able to merge when the remaining reviews on the Python scripts are solved :)
Sorry, something went wrong.
In InfiniTimeOrg#1097 new font generation capabilites were added. Generalize the font creation to make it possible to reuse the `displayapp/fonts/CMakeLists.txt` file for `InfiniSim` and just add the new cmake file to the project and link against the new `infinitime_fonts` target. In the following a list of changes. Allow non-global installed `lv_font_conv` executable installed with ```sh npm install lv_font_conv@1.5.2 ``` In CMake we search for `lv_font_conv` executable. Add the found executable to the python script `generate.py`, to remove the need for `lv_font_conv` to be in the path. Search for `python3` executable, if CMake version 3.12 is available. Otherwise use `python` as hard coded executable. Instead of adding the generated fonts to `SOURCE_FILES` variable, create a static library `infinitime_fonts`. Link this library to the executables instead. Use `add_custom_target()` together with `add_custom_command()` to generate the font.c files once (like the original PR does).
|
@Riksu9000 fixed the always regenerating fonts. Now its generated only once (and if the fonts.json file is modified) |
Sorry, something went wrong.
Update InfiniTime to contain fix from InfiniTimeOrg/InfiniTime#1131
|
and maybe it's make sense to note, that "node" version must be a fresh one...
and it looks like the known issue like this and this. |
Sorry, something went wrong.
I actually knew that, (which is why the docker installs npm's repos), and really should have kept track for such an issue.. (and added some comment somewhere about it) Added pr #1142 , which adds this info to the docs. |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
In #1097 new font
generation capabilites were added. Generalize the font creation to
make it possible to reuse the displayapp/fonts/CMakeLists.txt file
for InfiniSim and just add the new cmake file to the project and
link against the new infinitime_fonts target.
In the following a list of changes.
Allow non-global installed lv_font_conv executable installed with
In CMake we search for lv_font_conv executable. Add the found
executable to the python script generate.py, to remove the need for
lv_font_conv to be in the path.
Search for python3 executable, if CMake version 3.12 is available.
Otherwise use python as hard coded executable.
Instead of adding the generated fonts to SOURCE_FILES variable, create
a static library infinitime_fonts instead. Link this library to the
executables instead.