FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ImmediateAlertService: fix latent bug by DavisNT · Pull Request #2159 · InfiniTimeOrg/InfiniTime · GitHub

/ InfiniTime Public

ImmediateAlertService: fix latent bug - #2159

Merged
NeroBurner merged 1 commit into
InfiniTimeOrg:mainfrom
DavisNT:fixias
Nov 4, 2025
ConversationCommits (1)ChecksFiles changed
Merged

ImmediateAlertService: fix latent bug#2159
NeroBurner merged 1 commit into
InfiniTimeOrg:mainfrom
DavisNT:fixias

Conversation

DavisNT commented Nov 3, 2024

Copy link
Copy Markdown
Contributor

Include null terminator in the bytes copied.
Set notif.size like it is done in AlertNotificationService.cpp and AlertNotificationClient.cpp.

ImmediateAlertService: fix latent bug
b4979f5 
Include null terminator in the bytes copied.
Set notif.size as it is done in AlertNotificationService.cpp and
AlertNotificationClient.cpp.
DavisNT mentioned this pull request Nov 3, 2024
Merged

github-actions Bot commented Nov 3, 2024 •
edited
Loading

Copy link
Copy Markdown

Build size and comparison to main:

Section Size Difference
text 374512B -16B
data 948B 0B
bss 63488B 0B

FintasticMan approved these changes Nov 4, 2024
View reviewed changes

FintasticMan left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm fine with this implementation, but I think that it might be good to also use std::min to avoid overflowing the buffer. (Of course that isn't possible with the current notification strings, but it makes the code more clear if we do that)

Because there are some inconsistencies and incorrect handlings of the notification buffer elsewhere in the code, I'm thinking of adding a constructor to the struct that makes sure it's written correctly. In the meantime, this is a good fix.

DavisNT commented Nov 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@FintasticMan Thanks for the review!
In this particular case the alertString is one of string constants defined in lines 20-26 of ImmediateAlertService.cpp and is never longer than 12 characters (unless someone would modify this code).

In general constructor for NotificationManager::Notification that checks for buffer overflows sounds like a very good idea. 👍

P.S. Would you like me to implement this constructor?

FintasticMan commented Nov 5, 2024

Copy link
Copy Markdown
Member

I was planning on doing it, but if you want to, go ahead!

mark9064 added the maintenance Background work label Nov 18, 2024
NeroBurner added this to the 1.16.0 milestone Sep 3, 2025
NeroBurner requested a review from mark9064 September 3, 2025 18:53
mark9064 approved these changes Sep 4, 2025
View reviewed changes

mark9064 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

At a glance seems fine to me - haven't looked at the code around this though

Refactoring this problem away would be better but that can be done another time

DavisNT commented Sep 4, 2025

Copy link
Copy Markdown
Contributor Author

@mark9064, @NeroBurner Should I do the refactoring (implement a constructor for NotificationManager::Notification that checks for buffer overflows)?

mark9064 commented Sep 7, 2025

Copy link
Copy Markdown
Member

That would be great :)

DavisNT mentioned this pull request Oct 2, 2025
Open

DavisNT commented Oct 2, 2025

Copy link
Copy Markdown
Contributor Author

I have made a new PR with the refactoring: #2347
It also requires corresponding changes in InfiniSim: InfiniTimeOrg/InfiniSim#181

NeroBurner merged commit 74cf69b into InfiniTimeOrg:main Nov 4, 2025
metaphys pushed a commit to metaphys/InfiniTime that referenced this pull request Mar 30, 2026
ImmediateAlertService: fix latent bug (InfiniTimeOrg#2159)
98e5fcf 
Include null terminator in the bytes copied.
Set notif.size as it is done in AlertNotificationService.cpp and
AlertNotificationClient.cpp.
iakat pushed a commit to iakat/InfiniTime that referenced this pull request Jun 8, 2026
ImmediateAlertService: fix latent bug (InfiniTimeOrg#2159)
43dd2ae 
Include null terminator in the bytes copied.
Set notif.size as it is done in AlertNotificationService.cpp and
AlertNotificationClient.cpp.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JF002 JF002 approved these changes
NeroBurner NeroBurner approved these changes
mark9064 mark9064 approved these changes
FintasticMan FintasticMan approved these changes

Assignees

No one assigned

Labels

maintenance Background work

Projects

None yet

Milestone

1.16.0

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL