FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Release wakelock when timer Reset is pressed so screen will go to sleep by SteveAmor · Pull Request #2464 · InfiniTimeOrg/InfiniTime · GitHub

/ InfiniTime Public

Release wakelock when timer Reset is pressed so screen will go to sleep - #2464

Open
SteveAmor wants to merge 1 commit into
InfiniTimeOrg:mainfrom
SteveAmor:patch-2
ConversationCommits (1)ChecksFiles changed
Open

Release wakelock when timer Reset is pressed so screen will go to sleep#2464
SteveAmor wants to merge 1 commit into
InfiniTimeOrg:mainfrom
SteveAmor:patch-2

Conversation

SteveAmor commented Aug 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #2419
Tested on watch hardware

SteveAmor mentioned this pull request Aug 2, 2026
Open
1 task

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown

Build size and comparison to main:

Section Size Difference
text 385232B 0B
data 944B 0B
bss 22640B 0B

Run in InfiniEmu

mark9064 approved these changes Aug 8, 2026
View reviewed changes

mark9064 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm wondering if this should be in the Reset() function instead. But I think this might be more correct, the wakelock should release on the transition from ringing <10s to >10s, and also from ringing <10s to stopped / reset.

mark9064 added the bug Something isn't working label Aug 8, 2026
mark9064 added this to the 1.17.0 milestone Aug 8, 2026

SteveAmor commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

I'm still not really sure if it should go in Reset() or not. There were a few reasons I put it where it is. First was so that it was very clear what is happening, second was to save unnecessarily releasing the wakelock when other functions call Reset() but the release is not strictly required, and the third was that I didn't spot any refactoring that would result in a reduction in program size to move it to Reset().
Happy to move to Reset() if my thought process is flawed/not a good design etc.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mark9064 mark9064 approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

1.17.0

Development

Successfully merging this pull request may close these issues.

Screen doesn't go to sleep after reset countdown app

2 participants

Back | FazBrowse Home | New Git URL