FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Clarify Contributor workbook question by rrrutledge · Pull Request #446 · InnerSourceCommons/InnerSourceLearningPath · GitHub

/ InnerSourceLearningPath Public

Clarify Contributor workbook question - #446

Merged
rrrutledge merged 1 commit into
masterfrom
workbook/contributor
Sep 6, 2021
ConversationCommits (1)ChecksFiles changed
Merged

Clarify Contributor workbook question#446
rrrutledge merged 1 commit into
masterfrom
workbook/contributor

Conversation

rrrutledge commented Aug 20, 2021

Copy link
Copy Markdown
Contributor

Fixes #122

rrrutledge requested a review from a team as a code owner August 20, 2021 13:45
lenucksi added the Workbook Related to the Workbook label Aug 30, 2021
lenucksi approved these changes Aug 30, 2021
View reviewed changes

lenucksi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I like those clarifications and they LGTM but would like to hint to another addition @Ludmila-N made in #122 (comment):
"Question 1, answer 4 has the explanation that was never mentioned in the video, suggest rewriting this option:" (Contributor section, Contributor Ethos)

Maybe we can get another commit on those before we merge it? Maybe we can rephrase it along the lines of "a proven pattern for this problem ist ... 30-days-of-warranty" or so?

rrrutledge commented Sep 2, 2021

Copy link
Copy Markdown
Contributor Author

Question 1, answer 4 has the explanation that was never mentioned in the video

Although not in the video, it is in the article, which we've said before is fair game.

rrrutledge merged commit 18218b9 into master Sep 6, 2021
rrrutledge deleted the workbook/contributor branch September 6, 2021 15:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lenucksi lenucksi approved these changes
MaineC Awaiting requested review from MaineC
Ludmila-N Awaiting requested review from Ludmila-N

Assignees

No one assigned

Labels

Workbook Related to the Workbook

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Check videos against workbook after creation

2 participants

Back | FazBrowse Home | New Git URL